Sourcery refactored main branch by sourcery-ai[bot] · Pull Request #1 · edson-github/python-mini-project

sourcery-ai · 2023-07-19T22:48:57Z

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai

Due to GitHub API limits, only the first 60 comments can be shown.

sourcery-ai · 2023-07-19T22:49:00Z

Binary_tree/tree.py

-            if node.left is not None:
-                self._add(data, node.left)
-            else:
+            if node.left is None:
                node.left = Node(data)
-        else:
-            if node.right is not None:
-                self._add(data, node.right)
            else:
-                node.right = Node(data)
+                self._add(data, node.left)
+        elif node.right is not None:
+            self._add(data, node.right)
+        else:
+            node.right = Node(data)


Function Tree._add refactored with the following changes:

Merge else clause's nested if statement into elif (merge-else-if-into-elif)

Swap if/else branches (swap-if-else-branches)

sourcery-ai · 2023-07-19T22:49:00Z

Binary_tree/tree.py

-        if self.root is not None:
-            return self._find(data, self.root)
-        else:
-            return None
+        return self._find(data, self.root) if self.root is not None else None


Function Tree.find refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-07-19T22:49:00Z

Binary_tree/tree.py

-            print(str(node.data) + ' ')
+            print(f'{str(node.data)} ')


Function Tree._printTree refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-07-19T22:49:00Z

Caesar_Cipher/Caesar_cipher.py

-        output = "" 
+        output = ""
        string = string.lower()
-        string = string.strip()
-        if string == "":
+        if not (string := string.strip()):
            return(self.blank_string)
-        else: 
-            for c in string:
-                for k,v in self.key.items():
-                    if v == c:
-                        output += k
-
+        for c in string:
+            for k,v in self.key.items():
+                if v == c:
+                    output += k
+


Function main.decrypt_string refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

Swap if/else branches [×2] (swap-if-else-branches)

Replaces an empty collection equality with a boolean operation (simplify-empty-collection-comparison)

Remove unnecessary else after guard condition (remove-unnecessary-else)

sourcery-ai · 2023-07-19T22:49:00Z

Caterpillar_Game/Caterpillar.py

    (x,y) = caterpillar.pos()
-    outside = x < left_wall or x > right_Wall or y > top_wall or y < bottom_wall
-    return outside
+    return x < left_wall or x > right_Wall or y > top_wall or y < bottom_wall


Function outside_window refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-07-19T22:49:02Z

Egg_Catcher/eggcatcher.py

-    c.itemconfigure(lives_text , text='Lives : ' + str(lives_remaning))
+    c.itemconfigure(lives_text, text=f'Lives : {lives_remaning}')


Function lose_a_life refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

Remove unnecessary calls to str() from formatted values in f-strings (remove-str-from-fstring)

sourcery-ai · 2023-07-19T22:49:03Z

Egg_Catcher/eggcatcher.py

-    c.itemconfigure(score_text , text='Score : ' + str(score))
+    c.itemconfigure(score_text, text=f'Score : {str(score)}')


Function increase_score refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-07-19T22:49:03Z

Email Slicer/EmailSlicer.py

-
-    if(re.fullmatch(regex, email)):
-        return True
-    else:
-        return False
+
+    return bool((re.fullmatch(regex, email)))


Function isValidEmail refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify boolean if expression (boolean-if-exp-identity)

sourcery-ai · 2023-07-19T22:49:03Z

Email Slicer/EmailSlicer.py

-    username = email[0:email.index('@')]
+    username = email[:email.index('@')]


Lines 16-16 refactored with the following changes:

Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (remove-redundant-slice-index)

sourcery-ai · 2023-07-19T22:49:03Z

Encode_Morse.py/main.py

-  'A': '.-', 'B': '-...', 'C': '-.-.', 'D': '-..', 'E': '.', 'F': '..-.',
-  'G': '--.', 'H': '....', 'I': '..', 'J': '.---', 'K': '-.-', 'L': '.-..',
-  'M': '--', 'N': '-.', 'O': '---', 'P': '.--.', 'Q': '--.-', 'R': '.-.',
-  'S': '...', 'T': '-', 'U': '..-', 'V': '...-', 'W': '.--', 'X': '-..-',
-  'Y': '-.--', 'Z': '--..', ' ': ' ', '0': '-----',
-  '1': '.----', '2': '..---', '3': '...--', '4': '....-', '5': '.....',
-  '6': '-....', '7': '--...', '8': '---..', '9': '----.',
-  '&': '.-...', "'": '.----.', '@': '.--.-.', ')': '-.--.-', '(': '-.--.',
-  ':': '---...', ',': '--..--', '=': '-...-', '!': '-.-.--', '.': '.-.-.-',
-  '-': '-....-', '+': '.-.-.', '"': '.-..-.', '?': '..--..', '/': '-..-.'
+	'A': '.-', 'B': '-...', 'C': '-.-.', 'D': '-..', 'E': '.', 'F': '..-.',
+	'G': '--.', 'H': '....', 'I': '..', 'J': '.---', 'K': '-.-', 'L': '.-..',
+	'M': '--', 'N': '-.', 'O': '---', 'P': '.--.', 'Q': '--.-', 'R': '.-.',
+	'S': '...', 'T': '-', 'U': '..-', 'V': '...-', 'W': '.--', 'X': '-..-',
+	'Y': '-.--', 'Z': '--..', ' ': ' ', '0': '-----',
+	'1': '.----', '2': '..---', '3': '...--', '4': '....-', '5': '.....',
+	'6': '-....', '7': '--...', '8': '---..', '9': '----.',
+	'&': '.-...', "'": '.----.', '@': '.--.-.', ')': '-.--.-', '(': '-.--.',
+	':': '---...', ',': '--..--', '=': '-...-', '!': '-.-.--', '.': '.-.-.-',
+	'-': '-....-', '+': '.-.-.', '"': '.-..-.', '?': '..--..', '/': '-..-.'
 	}
-	string=""
-	for x in message:
-		string+=char_to_dots[x.upper()]+' '
-	return string[0:-1]
+	string = "".join(f'{char_to_dots[x.upper()]} ' for x in message)
+	return string[:-1]


Function encode_morse refactored with the following changes:

Use str.join() instead of for loop (use-join)

Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (remove-redundant-slice-index)

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-07-19T22:49:07Z

Execute Shell Command/execute_shell_command.py

-            print(str(err))
+            print(err)
        return out, return_code
    except Exception as err:
-        print("Exception Occurred while executing module : %s", str(err))
+        print("Exception Occurred while executing module : %s", err)


Function execute_shell_command refactored with the following changes:

Remove unnecessary call to str() within print() [×2] (remove-str-from-print)

sourcery-ai · 2023-07-19T22:49:08Z

Face_Recognition/main.py

-    cv2.data.haarcascades + "haarcascade_frontalface_default.xml")
+    f"{cv2.data.haarcascades}haarcascade_frontalface_default.xml"
+)
 body_cascade = cv2.CascadeClassifier(
-    cv2.data.haarcascades + "haarcascade_fullbody.xml")
+    f"{cv2.data.haarcascades}haarcascade_fullbody.xml"
+)


Lines 6-8 refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

sourcery-ai · 2023-07-19T22:49:08Z

Finding_Lanes/lanes.py

    blur = cv2.GaussianBlur(gray, (5, 5), 0)
-    canny = cv2.Canny(blur, 50, 150)
-    return canny
+    return cv2.Canny(blur, 50, 150)


Function canny refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-07-19T22:49:08Z

Finding_Lanes/lanes.py

-    masked_image = cv2.bitwise_and(image, mask)
-    return masked_image
+    return cv2.bitwise_and(image, mask)


Function roi refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-07-19T22:49:08Z

Firebase_Authentication_Using_Flask/main.py

-    if 'user' in session:
-        return redirect("/")
-    return render_template("login.html")
+    return redirect("/") if 'user' in session else render_template("login.html")


Function login refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-07-19T22:49:11Z

Slideshare to PDF/main.py

        imagesJPG = []

-        for index, link in enumerate(imgSRC):
+        for link in imgSRC:


Function get_pdf refactored with the following changes:

Remove unnecessary calls to enumerate when the index is not used (remove-unused-enumerate)

Replace f-string with no interpolated values with string (remove-redundant-fstring)

sourcery-ai · 2023-07-19T22:49:11Z

Smart_Calculator/calculator.py

 def lcm(a,b):
    if a<0 or b<0: return
-    L = a if a > b else b
+    L = max(a, b)


Function lcm refactored with the following changes:

Replace comparison with min/max call (min-max-identity)

sourcery-ai · 2023-07-19T22:49:11Z

Smart_Calculator/calculator.py

 def hcf(a,b):
    if a<0 or b<0: return
-    H = a if a<b else b
+    H = min(a, b)


Function hcf refactored with the following changes:

Replace comparison with min/max call (min-max-identity)

sourcery-ai · 2023-07-19T22:49:12Z

Snake_game/main.py

    # Size and font of score label (Top-Left)
    score_font = pygame.font.SysFont("arial", 15)
-    value = score_font.render(" Score: " + str(score), True, white)
+    value = score_font.render(f" Score: {str(score)}", True, white)


Function score refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-07-19T22:49:12Z

Snake_game/main.py

-        snake_Head = []
-        snake_Head.append(x1)
-        snake_Head.append(y1)
+        snake_Head = [x1, y1]


Function gameLoop refactored with the following changes:

Merge append into list declaration [×2] (merge-list-append)

sourcery-ai · 2023-07-19T22:49:15Z

Speaking_Wikipedia/speaking_wikipedia.py

-    content = wikipedia.summary(title, sentences = sentences)
-
-    return content
+    return wikipedia.summary(title, sentences = sentences)


Function page refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-07-19T22:49:15Z

Speaking_Wikipedia/speaking_wikipedia.py

-    if specify_num_of_sentences == "y" or specify_num_of_sentences == "Y":
+    if specify_num_of_sentences in ["y", "Y"]:


Function main refactored with the following changes:

Replace multiple comparisons of same variable with in operator (merge-comparisons)

sourcery-ai · 2023-07-19T22:49:16Z

Spinning Donut/spinningdonut.py

-            o = int(x + columns * y)  
+            o = int(x + columns * y)
            N = int(8 * ((f * e - c * d * g) * m - c * d * e - f * g - l * d * n))  # luminance index
            if rows > y and y > 0 and x > 0 and columns > x and D > z[o]:
                z[o] = D
-                b[o] = chars[N if N > 0 else 0]
+                b[o] = chars[max(N, 0)]


Lines 76-97 refactored with the following changes:

Replace comparison with min/max call (min-max-identity)

Swap if/else to remove empty if body (remove-pass-body)

Hoist repeated code outside conditional statement [×2] (hoist-statement-from-if)

Swap positions of nested conditionals [×2] (swap-nested-ifs)

sourcery-ai · 2023-07-19T22:49:16Z

Sqlite-crud/main.py

            parameters =  (self.name.get(), self.price.get())
            self.run_query(query, parameters)
-            self.message['text'] = 'Product {} added Successfully'.format(self.name.get())
+            self.message['text'] = f'Product {self.name.get()} added Successfully'


Function Product.add_product refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

sourcery-ai · 2023-07-19T22:49:16Z

Sqlite-crud/main.py

        query = 'DELETE FROM product WHERE name = ?'
        self.run_query(query, (name, ))
-        self.message['text'] = 'Record {} deleted Successfully'.format(name)
+        self.message['text'] = f'Record {name} deleted Successfully'


Function Product.delete_product refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

sourcery-ai · 2023-07-19T22:49:18Z

TEXTVENTURE/game.py

-    count = 0
-
-    for obj in ZONE_MAP:
-        if obj["SOLVED"]: count += 1
-
+    count = sum(1 for obj in ZONE_MAP if obj["SOLVED"])


Function ifSolved refactored with the following changes:

Convert for loop into call to sum() (sum-comprehension)

sourcery-ai · 2023-07-19T22:49:18Z

TEXTVENTURE/game.py

-        
+


Function setup_game refactored with the following changes:

Simplify conditional into switch-like form [×5] (switch)

Use f-string instead of string concatenation [×4] (use-fstring-for-concatenation)

sourcery-ai · 2023-07-19T22:49:18Z

TestTypingSpeed/TestTypingSpeed.py

-    print("Let's Start")   
+    print("Let's Start")
    typing_speed()

-    while True :  
-        if input("Do you want to try again? (y/n): ")=="y":
-            print("\n")
-            typing_speed()
-        else:
-            break    
+    while True:  
+        if input("Do you want to try again? (y/n): ") != "y":
+            break
+        print("\n")
+        typing_speed()    


Lines 39-47 refactored with the following changes:

Swap if/else branches (swap-if-else-branches)

Remove unnecessary else after guard condition (remove-unnecessary-else)

sourcery-ai · 2023-07-19T22:49:18Z

Tic_Tac_Toe/tic_tac_toe.py

-#initialize 
-board = [' ' for x in range(10)]
+#initialize
+board = [' ' for _ in range(10)]


Lines 5-6 refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

sourcery-ai · 2023-07-19T22:49:18Z

Tic_Tac_Toe/tic_tac_toe.py

-    print(' ' + board[1] + ' | ' + board[2] + ' | ' + board[3])
+    print(f' {board[1]} | {board[2]} | {board[3]}')
    print('-----------')
-    print(' ' + board[4] + ' | ' + board[5] + ' | ' + board[6])
+    print(f' {board[4]} | {board[5]} | {board[6]}')
    print('-----------')
-    print(' ' + board[7] + ' | ' + board[8] + ' | ' + board[9])
+    print(f' {board[7]} | {board[8]} | {board[9]}')


Function printBoard refactored with the following changes:

Use f-string instead of string concatenation [×15] (use-fstring-for-concatenation)

'Refactored by Sourcery'

74b1f30

sourcery-ai bot requested a review from edson-github July 19, 2023 22:48

sourcery-ai bot commented Jul 19, 2023

View reviewed changes

		c.itemconfigure(lives_text , text='Lives : ' + str(lives_remaning))
		c.itemconfigure(lives_text, text=f'Lives : {lives_remaning}')

		c.itemconfigure(score_text , text='Score : ' + str(score))
		c.itemconfigure(score_text, text=f'Score : {str(score)}')

		username = email[0:email.index('@')]
		username = email[:email.index('@')]

		if specify_num_of_sentences == "y" or specify_num_of_sentences == "Y":
		if specify_num_of_sentences in ["y", "Y"]:

Conversation

sourcery-ai bot commented Jul 19, 2023

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jul 19, 2023

Choose a reason for hiding this comment