Revert "default.html: remove site.baseurl from anchors (#145)" #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit a4cd697. That commit breaks the changed nav links on /blog, as the anchors are specific to / (i.e.: the home page).
Contributor
Author
|
Sorry about that; I forgot that there are more pages and that the nav is global |
xuhdev
approved these changes
Apr 6, 2021
Member
|
Nice catch again! Thanks! |
Contributor
Author
|
I recently noticed this: commit 67a887a ("Add a Jekyll-based blog (#57)"). $ git show --pretty='' 67a887aa -- _layouts/default.html | grep '#'
- <li><a href="#overview">What is EditorConfig?</a></li>
- <li><a href="#example-file">Example File</a></li>
- <li><a href="#file-location">File Location</a></li>
- <li><a href="#file-format-details">File Format Details</a></li>
- <li><a href="#download">Download a Plugin</a></li>
- <li><a href="#contributing">Contributing</a></li>
+ <li><a href="{{ site.baseurl }}/#overview">What is EditorConfig?</a></li>
+ <li><a href="{{ site.baseurl }}/#example-file">Example File</a></li>
+ <li><a href="{{ site.baseurl }}/#file-location">File Location</a></li>
+ <li><a href="{{ site.baseurl }}/#file-format-details">File Format Details</a></li>
+ <li><a href="{{ site.baseurl }}/#download">Download a Plugin</a></li>
+ <li><a href="{{ site.baseurl }}/#contributing">Contributing</a></li>Wish I had seen that earlier hehe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a4cd697.
That commit breaks the changed nav links on /blog, as the anchors are
specific to / (i.e.: the home page).
Link to the original PR: #145.