Update solution for services v1 and transaction v2#7
Merged
hellt merged 2 commits intosrx-2025-solutionfrom Aug 30, 2025
Merged
Update solution for services v1 and transaction v2#7hellt merged 2 commits intosrx-2025-solutionfrom
hellt merged 2 commits intosrx-2025-solutionfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the solution to use services v1 API instead of v1alpha1 and transaction v2 API instead of v1, along with upgrading the pydantic-eda dependency from v0.3.2 to v0.4.0.
- Updated import statements and API versions from v1alpha1 to v1 for services
- Migrated transaction API from v1 to v2 with improved error handling
- Enhanced EDAClient constructor to accept username/password parameters
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/virtualnetwork.py | Updated services import from v1alpha1 to v1 and reformatted long parameter lists |
| src/client.py | Migrated from transaction v1 to v2 API with enhanced error handling and authentication |
| pyproject.toml | Upgraded pydantic-eda dependency from v0.3.2 to v0.4.0 |
| main.py | Updated EDAClient instantiation to include username and password parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| eda = EDAClient( | ||
| base_url="https://<your_group_id>.srexperts.net:9443", | ||
| username="admin", | ||
| password="<fill in the password>", |
There was a problem hiding this comment.
Hardcoded placeholder password in production code creates a security risk. Consider using environment variables or a secure configuration mechanism instead of placeholder text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.