Skip to content

infra: fix dash internal checks#34

Open
PiotrKorkus wants to merge 1 commit intoeclipse-score:mainfrom
qorix-group:piotrkorkus_fix_dash_check
Open

infra: fix dash internal checks#34
PiotrKorkus wants to merge 1 commit intoeclipse-score:mainfrom
qorix-group:piotrkorkus_fix_dash_check

Conversation

@PiotrKorkus
Copy link
Contributor

@PiotrKorkus PiotrKorkus commented Jan 27, 2026

  • Use correct Cargo.lock file
  • Filter out local depenendencies as only 3rd party should be checked

Bugfix

Important

Use this template only for bugfixes that do not influence topics covered by contribution requests or improvements.

Caution

Make sure to submit your pull-request as Draft until you are ready to have it reviewed by the Committers.

Description

[A short description of the bug being fixed by the contribution.]

Related ticket

Important

Please replace [ISSUE-NUMBER] with the issue-number that tracks this bug fix. If there is no such
ticket yet, create one via this issue template.

closes #16

@github-actions
Copy link

github-actions bot commented Jan 27, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 8dfc2e5f-fe68-4b3b-8892-27825de796a6
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-LTilyiMMjpYyAi1PW+8RycyAEHy9clo7915R0Bchb2E="
DEBUG: Repository rules_boost+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.2.8, but got rules_cc@0.2.14 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)

Analyzing: target //:license-check (71 packages loaded, 9 targets configured)

Analyzing: target //:license-check (113 packages loaded, 206 targets configured)

Analyzing: target //:license-check (150 packages loaded, 2897 targets configured)

Analyzing: target //:license-check (156 packages loaded, 7056 targets configured)

Analyzing: target //:license-check (156 packages loaded, 7056 targets configured)

INFO: Analyzed target //:license-check (159 packages loaded, 9072 targets configured).
[11 / 14] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 250 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 14.171s, Critical Path: 0.37s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copilot AI reviewed Jan 27, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the internal DASH license checker configuration by correcting the Cargo.lock file path and filtering out local dependencies to ensure only third-party packages are checked.

Changes:

  • Removed the copyright_checker rule
  • Added a genrule to filter local dependencies from Cargo.lock
  • Updated dash_license_checker to use the filtered Cargo.lock file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

BUILD
template = "@score_tooling//cr_checker/resources:templates",
visibility = ["//visibility:public"],
# Needed for Dash tool to check python dependency licenses.
# This is a workaround to filter out local packages from the Cargo.lock file.
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'depenendencies' to 'dependencies' in comment.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

The created documentation from the pull request is available at: docu-html

@PiotrKorkus
infra: fix dash internal checks
e6858e7 
- Use correct Cargo.lock file
- Filter out local depenendencies as only 3rd party should be checked
@PiotrKorkus PiotrKorkus force-pushed the piotrkorkus_fix_dash_check branch from 78700e1 to e6858e7 Compare January 27, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@FScholPer FScholPer FScholPer approved these changes

@johannes-esr johannes-esr Awaiting requested review from johannes-esr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some dependencies need to be vetted

2 participants

@PiotrKorkus @FScholPer