Update supported Python and package versions.#14
Draft
tbreckle wants to merge 1 commit intoeclipse-score:mainfrom
Draft
Update supported Python and package versions.#14tbreckle wants to merge 1 commit intoeclipse-score:mainfrom
tbreckle wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
tbreckle
force-pushed
the
feature/update-python-versions
branch
from
40e06c1 to
4d68282
Compare
* [Python] Add mechanism to support EOL (legacy) Python versions Versions that are end of life (currently 3.8 and 3.9) are marked as legacy versions and have a separated requirements file to split dependencies and support both, legacy and stable versions. * [Python] Add new stable versions Add new stable versions (3.13 and 3.14). * [pip] Update dependencies Updated dependencies for tools, partly to support new versions , to have new features available, fix pip-audit findings or to be in sync with other S-CORE repos.
tbreckle
force-pushed
the
feature/update-python-versions
branch
from
4d68282 to
28973f6
Compare
jannowotsch
suggested changes
Feb 6, 2026
| - bazel_skylib >= 1.7.1 | ||
| - rules_python >= 1.4.1 | ||
| - bazel_skylib >= 1.9.0 | ||
| - rules_python >= 1.7.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| - rules_python >= 1.7.0 | |
| - rules_python >= 1.6.3 |
according to MODULES.bazel
| for version in PYTHON_VERSIONS | ||
| ] | ||
|
|
||
| [ |
Contributor
There was a problem hiding this comment.
Would it be possible to issue the warning only if the selected python version is a legacy one?
|
|
||
| This will try to read the requirements.in file as well as | ||
| requirements.in_stable and requirements.in_legacy. In case one of those files | ||
| do not exist it will be simply skipped. |
Contributor
There was a problem hiding this comment.
Suggested change
| do not exist it will be simply skipped. | |
| does not exist it will be simply skipped. |
| if not requirements: | ||
| fail("No direct dependencies found in any requirements file. The created pip hub will be empty.") | ||
|
|
||
| return list(requirements.keys()) |
Contributor
There was a problem hiding this comment.
if we anyhow return a list, would be possible to skip the dictionary step and just add the lists returned by _read_and_parse_requirements?
| [ | ||
| python_tool_common.Finding( | ||
| path=pathlib.Path("file.py"), | ||
| path=pathlib.Path(" file.py"), |
Contributor
There was a problem hiding this comment.
wa sthis change made on purpose?
| run_command "test/run_all_tests.sh" "tests (in test workspace)" | ||
| fi | ||
|
|
||
| if [ "${workspace}" == "all" -o "${workspace}" == "test_single_version" ];then |
Contributor
There was a problem hiding this comment.
Personally, I would not have another test workspace, since it doesn't cover anything in addition to the already existing one. I guess test_single_version would be a good template for someone that just wants to use bazel-tools-python, but for that use-case I would rather update the documentation, if it is not good enough.
Anyhow, that's just my opinion and I asked a colleague of mine, what we want to do.
Contributor
There was a problem hiding this comment.
My colleague agree, we should stick to one test workspace.
| build --config=python_3_8 | ||
| build:python_3_13 --python=3.13 | ||
| build:python_3_14 --python=3.14 | ||
| build --config=python_3_12 |
Contributor
There was a problem hiding this comment.
Is it required to switch to 3.12 or is that a leftover from when you removed 3.8 entirely? If possible I'd keep 3.8 until we can really remove it.
Contributor
There was a problem hiding this comment.
Here my colleague also agreed. We have to test against 3.8 by default, to ensure no-one introduces anything that doesn't work with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Python] Remove EOL versions
Remove versions that are end of life (3.8 and 3.9).
[Python] Add new stable versions
Add new stable versions (3.13 and 3.14).
[pip] Update dependencies
Updated dependencies for tools, partly to support new versions , to have new features available, fix pip-audit findings or to be in sync with other S-CORE repos.