Skip to content

Conversation

@eadouglas
Copy link
Owner

No description provided.

Copy link
Collaborator

@Velsu Velsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eustace Your prototype-refactor exercises look fine, You succesfully converted classes to ES6 syntax. There is no need for prototypes there tho because they can cause conflicts. Also any methods for classes should also be defined for a class with ES6 way and not on prototype.

The Person class from lambda-classes has been written properly but the other crucial pieces of code are completely missing. There is no way to test the code as it is and there are Instructor and Student classes missing, along with few more.

I can see You are slowly improving and this might be challenging for someone doing his first steps but i would really like to encourage You to go back to these exercises over the weekend and try to work on them a little more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants