Skip to content

Preserve terminal resume errors and allow later async retries - #91

Merged
vishale6x merged 1 commit into
mainfrom
vishal/python-resume-error-fix-20261103
Nov 6, 2026
Merged

vishale6x merged 1 commit into
mainfrom
vishal/python-resume-error-fix-20261103

Conversation

@vishale6x

@vishale6x vishale6x commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

When auto-resume is disabled, sync recovery swallowed the operator's FAILED_PRECONDITION, while async recovery hid the reason and retained pending state that blocked a later valid retry. Preserve the original sync error, include the server reason in async OperationalError with its original cause, and clear pending state only when the Resume RPC itself receives FAILED_PRECONDITION.

Validation:

  • Four real-service regressions failed on unchanged code and passed after the fix. The same async manager resumed successfully after re-enable and completed SELECT 1.
  • Full Linux matrix passed on Python 3.11 minimum/current, 3.12 current, and 3.13 current: 2,443 passed per lane, 42 or 43 live-gated skips, and one existing expected failure.
  • Nine wheel import checks passed across Python 3.11/3.12/3.13 and base/async/async-sqlalchemy installs. Packaged sync and async SELECT 1 passed. Independent review found no new defect.

Coverage combines only candidate suite and patched live data, with no new exclusions:

Scope Line coverage Branch coverage
Project 93.798% 88.809%
Sync manager 95.224% 80.114%
Async manager 93.534% 85%
Changed code 8/8 (100%) 6/6 (100%)

Draft limits:

  • Live OAuth and broader supported-engine compatibility remain unverified.
  • All macOS matrix lanes retain the same 16 pre-existing benchmark/environment and closed-port timing failures seen before this change.
  • The existing alternate-strategy helper can preserve the first 456 error instead of a later terminal error. That separate edge was not reproduced on the current operator route and remains a follow-up under the approved scope.

Related changes: JDBC resume routing #249 and automation regressions #196. Connector releases remain separate; this PR does not publish a package.

@vishale6x
vishale6x marked this pull request as ready for review November 5, 2026 05:36
@vishale6x
vishale6x merged commit 8417475 into main Nov 6, 2026
10 checks passed
@vishale6x
vishale6x deleted the vishal/python-resume-error-fix-20261103 branch November 6, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants