Conversation
Co-authored-by: jkingston <jkingston@duckduckgo.com>
|
Cursor Agent can help with this pull request. Just |
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 23 Jan 2026 20:24:28 GMT Android
File has changed |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if (processedConfig.debug) { | ||
| console.error('Android: Initial ping skipped after init failure:', error); | ||
| } | ||
| } |
There was a problem hiding this comment.
Initialization errors now silently swallowed in production
Low Severity
The new try-catch block changes error visibility behavior. Previously, init() was called without await, so any errors would surface as unhandled promise rejections visible in the browser console. Now, errors from init() are caught and only logged when processedConfig.debug is true. In production environments where debug is false, init() failures will be completely silent with no console output, potentially making it harder to diagnose issues when initialization fails.
Please tell me if this was useful or not with a 👍 or 👎.
2 participants
Asana Task/Github Issue:
Description
Implements an initial ping for the Android bundle, notifying the native app when content scope scripts have been initialized. The
initialPingmessage is sent viaMessaging.notifyafter theinit()function completes ininjected/entry-points/android.js, but only for top-level frames.Testing Steps
initialPingmessage being sent from the injected script to the native Android app (requires Android-side logging/instrumentation to verify).Checklist
Please tick all that apply:
Note
Implements a native init notification for Android and adjusts init flow timing.
sendInitialPingusingMessaging/MessagingContext; skips whenisBeingFramed()load, awaitsinit(processedConfig)and on success callsmessaging.notify('initialPing'); on failure logs in debug and skips pinginjected/entry-points/android.jsWritten by Cursor Bugbot for commit 5f10541. This will update automatically on new commits. Configure here.