Repository navigation
Conversation
COPY replaces a single file via a tmp rename, so overwrite=False had no effect. Fail with the same IOException as partitioned writes instead of silently replacing the file.
This was referenced Sep 29, 2026
Member
Author
|
Sounds good, thanks for porting it over! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #633. Fixes #156.
to_parquet(..., overwrite=False)andto_csv(..., overwrite=False)currently still replace an existing file. The flag is forwarded as COPY'soverwrite_or_ignore, which only applies to partitioned output. For a single file, COPY writes to a tmp path and renames over the original, so the flag is a no-op.When
overwrite=Falseand the target already exists as a file, fail with the sameIOExceptionpartitioned writes already use (Enable OVERWRITE option to overwrite the file). Default behaviour (omitoverwrite) andoverwrite=Trueare unchanged.Tests in
tests/fast/api/test_to_parquet.pyandtests/fast/api/test_to_csv.pycover:overwrite=Falseerrors and leaves the original fileoverwrite=Truestill replaces a single fileValidation after upstream sync
Merged
v2.0-cyanopteraatb2d23c0ac04d5f778d020a044a54bafde0e20557, preserving the existing fix and tests. The include conflict was resolved by retainingfile_system.hppand accepting upstream removal of the obsolete Arrow collector include.pytest tests/fast/api/test_to_csv.py tests/fast/api/test_to_parquet.py: 47 passed.git diff --check: passed.