-
Notifications
You must be signed in to change notification settings - Fork 45
Fetch files via cgit.drupalcode.org directly #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Haven't tried it yet, but read through the changes and it looks fantastic. Great job. |
|
@greg-1-anderson Why is expected that the index.php is not present after the initial composer install? Both packages (the scaffold and drupal core) are in the composer.json. I can't spot the difference to the previous implementation. |
|
I just ran |
|
The only difference with the previous implementation was that the robo task was Does a local |
|
#40 failed after composer update. I change the test to match the new behaviour. It makes more sense anyway. Thanks @greg-1-anderson for your help. |
|
LGTM. Some minor changes to drupal-composer/drupal-project will be needed once this is merged. |
|
@greg-1-anderson Yes the version constraint. What else? |
|
I added a PR, drupal-composer/drupal-project#155 to demonstrate. I think it's about right, but have not tried it. |
Follow-up for #37
I tried to fix the async via guzzle in 69038ac#diff-972a789eb631b4e9b19070bc31cbe900L36 and was working in the test. It took lets than 4 seconds to fetch all files. But i hit composer/composer#4764 if i run it as composer plugin :/
Refactored everything and used composers RemoteFileSystem to get the job done. Documentation is not up to date yet.