Deprecate PHP 7.1 #518
Merged
Deprecate PHP 7.1 #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPParsley
commented
Sep 11, 2019
MPParsley
commented
Sep 11, 2019
Member
|
Thanks for the PR! |
This is not true yet, security support is maintained till 01-12-2019 the next drupal release still falls within this time frame (and will support 7.1 as far as I can tell). Is this intended? |
|
This is a bit heavy handed. Since this package is the official suggested way to install Drupal with composer (https://www.drupal.org/docs/develop/using-composer/using-composer-to-install-drupal-and-manage-dependencies) it would be useful if the official version constraints would be followed. Drupal 8.8 does not even require PHP 7.1 yet let alone a minimum of 7.2. |
webflo
added a commit
that referenced
this pull request
Sep 21, 2019
Member
|
Thanks for your feedback. I reverted the change and we will use 7.0.8 as the new minimum. |
omahm
added a commit
to dof-dss/nicsdru_cybersecurity
that referenced
this pull request
Oct 2, 2019
Reverting PHP 7.2 requirement, please see drupal-composer/drupal-project#518 (comment)
dannylamb
pushed a commit
to islandora-deprecated/drupal-project
that referenced
this pull request
Jan 2, 2020
* Honor .env files and suggest usage (drupal-composer#351) * Remove extra whitespace (drupal-composer#371) * Updated argument name * Bump minimal version * Bump minimal version to 8.5.3 * Fix installer path for drush commandfiles. * Update drupal-composer/drupal-scaffold drupal-composer/drupal-scaffold is a full featured plugin and provides its own command. * Fix tests on Travis CI (drupal-composer#405) * Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404) * Remove "drupal-scaffold" from scripts (drupal-composer#275) * Fix typo in README.md * Remove unused use statement. (drupal-composer#406) * Adjust default core patch level to -p2. (drupal-composer#418) * Bump minimum required composer-patches version to support default patch level (drupal-composer#410) * Update composer.json to require latest stable version of Drupal (drupal-composer#424) * Require zaporylie/composer-drupal-optimizations (drupal-composer#442) * Issue drupal-composer#408: Bump minimum PHP version to 5.6 * Removing redundant "--stability dev" from installation command (drupal-composer#450) Fixes drupal-composer#449. * Added "composer-exit-on-patch-failure": true option to composer.json (drupal-composer#420) * Sync new lines at the end of the files (drupal-composer#453) * Quote wildcards to avoid issues in some shells (drupal-composer#456) * Add PHP 7.3 to Travis CI (drupal-composer#476) * Change createRequiredFiles messages to reflect what occured (drupal-composer#467) * Drop PHP 5.6 testing (drupal-composer#489) * Bump minimum version to 8.7.0 (drupal-composer#488) * Update .travis.yml * Deprecate PHP 7.0 and 7.1 (drupal-composer#518) * Revert "Deprecate PHP 7.1" (drupal-composer#521) This reverts commit 5085410. * Issue drupal-composer#518: Bump minimum php version to 7.0.8 * Update CI to Ubuntu 18.04 (drupal-composer#520) * Revert "Update CI to Ubuntu 18.04" (drupal-composer#526) This reverts commit ee5bf36. * Add 'contrib' to Drush commandfile installer path (drupal-composer#525) * Prefer usage of && operator instead of "and" (drupal-composer#530) * update to drupal 8.8.0 * replace webflo/drupal-core-require-dev with drupal/core-dev * Use scaffold plugin and composer packages from Drupal core 8.8.0 (drupal-composer#522) * Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY * update to 8.8.1 Co-authored-by: Moshe Weitzman <weitzman@tejasa.com> Co-authored-by: Jakub Piasecki <jakub@piaseccy.pl> Co-authored-by: Markus Orenstrat <markus.orenstrat@reinblau.de> Co-authored-by: Florian Weber <florian@webflo.org> Co-authored-by: Rodrigo <hi@rodrigoaguilera.net> Co-authored-by: Norman Kämper-Leymann <leymannx@users.noreply.github.com> Co-authored-by: Alex Milkovskyi <a.milkovsky@gmail.com> Co-authored-by: Dezső BICZÓ <mxr576@users.noreply.github.com> Co-authored-by: Matthew Grasmick <matthew.grasmick@acquia.com> Co-authored-by: Andy Postnikov <apostnikov@gmail.com> Co-authored-by: Hans Fredrik Nordhaug <hansfn@gmail.com> Co-authored-by: Maarten Segers <MPParsley@users.noreply.github.com> Co-authored-by: Peter Kokot <peterkokot@gmail.com> Co-authored-by: Simon Perdrisat <perdrisat@gmail.com> Co-authored-by: Charles Tanton <charlietnt@gmail.com> Co-authored-by: Greg Anderson <greg.1.anderson@greenknowe.org> Co-authored-by: Paul <1727604+paulvandenburg@users.noreply.github.com>
zanvidmar
added a commit
to oscarsergeant/drupal-project
that referenced
this pull request
Feb 12, 2020
* Deprecate PHP 7.0 and 7.1 (drupal-composer#518) * Revert "Deprecate PHP 7.1" (drupal-composer#521) This reverts commit 5085410. * Issue drupal-composer#518: Bump minimum php version to 7.0.8 * Update CI to Ubuntu 18.04 (drupal-composer#520) * Revert "Update CI to Ubuntu 18.04" (drupal-composer#526) This reverts commit ee5bf36. * Add 'contrib' to Drush commandfile installer path (drupal-composer#525) * Prefer usage of && operator instead of "and" (drupal-composer#530) * Use scaffold plugin and composer packages from Drupal core 8.8.0 (drupal-composer#522) * Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY Co-authored-by: Maarten Segers <MPParsley@users.noreply.github.com> Co-authored-by: Florian Weber <florian@webflo.org> Co-authored-by: Greg Anderson <greg.1.anderson@greenknowe.org> Co-authored-by: Paul <1727604+paulvandenburg@users.noreply.github.com>
shrop
pushed a commit
to shrop/drupal-project
that referenced
this pull request
Apr 11, 2020
shrop
pushed a commit
to shrop/drupal-project
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.1 is no longer supported, let's remove it.
See https://www.php.net/supported-versions.php