Skip to content

Allow querying chainfind with sql conditions #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dxg merged 3 commits into from
Jul 18, 2013
Merged

Allow querying chainfind with sql conditions #233

dxg merged 3 commits into from
Jul 18, 2013

Conversation

@dxg
Copy link
Collaborator

@dxg dxg commented Jul 17, 2013

Enables:

Person.find({ age: 18 }).where("LOWER(surname) LIKE ?", ['dea%']).all( ... );
Person.find({ age: 18 }).find("LOWER(surname) LIKE ?", ['dea%']).all( ... );
Person.find({ age: 18, __sql: [["LOWER(surname) LIKE ?", ['dea%']]] }, function (err, items) { ... });

but I think we should only document the first version.

I named the key __sql to avoid any collisions with user specified model properties.

This addresses #225 and depends on dresende/node-sql-query#16 (I think tests will fail until that version of sql query is published).

@dresende
Copy link
Owner

dresende commented Jul 17, 2013

You could pass __sql in the options instead of conditions. This would avoid collisions. About only documenting the first one, I agree.

@dresende
Copy link
Owner

dresende commented Jul 17, 2013

It actually doesn't matter since sql-query is accepting it in conditions :)

@dresende
Copy link
Owner

dresende commented Jul 17, 2013

I just merged and published new sql-query version.

@dresende
Copy link
Owner

dresende commented Jul 17, 2013

It's just missing documentation :)

@dxg
Copy link
Collaborator Author

dxg commented Jul 17, 2013

I'll add doco and merge :)

dxg added a commit that referenced this pull request Jul 18, 2013
@dxg
Merge pull request #233 from dresende/find-sql
5c6c1ea 
Allow querying chainfind with sql conditions, closes #225
@dxg dxg merged commit 5c6c1ea into master Jul 18, 2013
@dxg dxg deleted the find-sql branch July 18, 2013 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dxg @dresende