Skip to content

refactor(engine-render): refactor text shaping logic#6645

Open
jikkai wants to merge 2 commits into
devfrom
refactor/optional-opentype
Open

refactor(engine-render): refactor text shaping logic#6645
jikkai wants to merge 2 commits into
devfrom
refactor/optional-opentype

Conversation

@jikkai
Copy link
Copy Markdown
Member

@jikkai jikkai commented Mar 5, 2026

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from Jocs as a code owner March 5, 2026 04:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

Playwright test results

passed  27 passed

Details

stats  27 tests across 12 suites
duration  7 minutes, 5 seconds
commit  3b1b679
info  For more information, see full report

@jikkai jikkai force-pushed the refactor/optional-opentype branch from 40002da to 3b1b679 Compare March 9, 2026 01:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.62%. Comparing base (d2d526b) to head (3b1b679).
⚠️ Report is 35 commits behind head on dev.

Files with missing lines Patch % Lines
...ponents/docs/layout/shaping-engine/text-shaping.ts 94.44% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6645      +/-   ##
==========================================
+ Coverage   50.51%   50.62%   +0.11%     
==========================================
  Files        2656     2656              
  Lines      146885   146917      +32     
  Branches    32967    32972       +5     
==========================================
+ Hits        74198    74379     +181     
+ Misses      72687    72538     -149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant