Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces backoff functionality for agent error handling and session tracking. The primary purpose is to add hooks that can automatically retry operations with exponential backoff when specific errors occur, particularly for rate limiting scenarios.
- Adds
session_id(ULID) to uniquely identify agent run sessions for tracking backoff state - Implements
backoff_on_errorandbackoff_on_ratelimithooks with exponential backoff logic - Updates all agent event dispatching to include the new session identifier
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dreadnode/agent/reactions.py | Fixed Field parameter syntax for optional messages field |
| dreadnode/agent/hooks/backoff.py | New backoff hook implementations with exponential retry logic |
| dreadnode/agent/hooks/init.py | Exports new backoff hooks in public API |
| dreadnode/agent/events.py | Adds session_id field to AgentEvent base class |
| dreadnode/agent/agent.py | Updates all event dispatching to include session_id parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backoff_on_errorandbackoff_on_ratelimithooks for agents.Generated Summary:
session_idof typeULIDto uniquely identify agent run sessions.AgentEventto includesession_id, improving traceability for events.session_id, ensuring consistent session tracking.ulidadded across relevant files to support the new identifier.messagesfield in theRetryreaction class to have a default value, making it optional.This summary was generated with ❤️ by rigging