Skip to content

fix: CDATA Escaping#217

Merged
monoxgas merged 1 commit intomainfrom
fix/cdata-escaping
Jul 24, 2025
Merged

fix: CDATA Escaping#217
monoxgas merged 1 commit intomainfrom
fix/cdata-escaping

Conversation

@monoxgas
Copy link
Contributor

@monoxgas monoxgas commented Jul 24, 2025 •
edited by github-actions bot
Loading

Notes

  • Fix a bug in CDATA auto-insertion that could cause failures

Generated Summary

  • Updated regex pattern in both docs/api/model.mdx and rigging/model.py to require a whitespace character before the tag attributes.
  • Wrapped the substitution result with an XML parsing check using ET.fromstring; if invalid XML is detected, the original content is returned.
  • These changes ensure that wrapping fields with CDATA does not accidentally produce malformed XML, maintaining data integrity.

This summary was generated with ❤️ by rigging

@monoxgas monoxgas requested a review from a team as a code owner July 24, 2025 00:10
@dreadnode-renovate-bot dreadnode-renovate-bot bot added area/docs Changes to documentation and guides type/docs Documentation updates and improvements labels Jul 24, 2025
@monoxgas monoxgas merged commit d1dd655 into main Jul 24, 2025
7 checks passed
@monoxgas monoxgas deleted the fix/cdata-escaping branch July 24, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/docs Changes to documentation and guides type/docs Documentation updates and improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@monoxgas