tests: refactor system tests

parthea · parthea · commit c5eadaba60dc · 2026-03-03T19:45:57.000Z
diff --git a/packages/google-auth/noxfile.py b/packages/google-auth/noxfile.py
@@ -15,7 +15,6 @@
 import os
 import pathlib
 import shutil
-import subprocess
 
 import nox
 
@@ -58,36 +57,6 @@
 ]
 
 
-def _provision_kokoro_secrets():
-    """Downloads CI secrets directly from GCS and formats them for the tests."""
-    if not os.environ.get("KOKORO_GFILE_DIR"):
-        return
-
-    dest_dir = pathlib.Path(__file__).parent / "data"
-    dest_dir.mkdir(parents=True, exist_ok=True)
-
-    # Map GCS filenames to the local filenames expected by tests
-    secrets_map = {
-        "google-auth-service-account.json": "service_account.json",
-        "google-auth-authorized-user.json": "authorized_user.json",
-        "google-auth-impersonated-service-account.json": "impersonated_service_account.json",
-    }
-
-    gcs_base = "gs://cloud-devrel-kokoro-resources/google-cloud-python"
-
-    for src_name, dest_name in secrets_map.items():
-        subprocess.run(
-            ["gcloud", "storage", "cp", f"{gcs_base}/{src_name}", str(dest_dir)],
-            check=True,
-            capture_output=True,
-        )
-        # Rename to use underscores as per test conventions
-        (dest_dir / src_name).replace(dest_dir / dest_name)
-
-
-_provision_kokoro_secrets()
-
-
 @nox.session(python=DEFAULT_PYTHON_VERSION)
 def lint(session):
     session.install(
diff --git a/packages/google-auth/system_tests/noxfile.py b/packages/google-auth/system_tests/noxfile.py
@@ -69,6 +69,37 @@
 # The full path to the gcloud cli executable.
 GCLOUD = str(CLOUD_SDK_INSTALL_DIR.joinpath("bin", "gcloud"))
 
+
+def _provision_kokoro_secrets():
+    """Downloads CI secrets directly from GCS and formats them for the tests."""
+    if not os.environ.get("KOKORO_GFILE_DIR"):
+        return
+
+    dest_dir = pathlib.Path(__file__).parent / "data"
+    dest_dir.mkdir(parents=True, exist_ok=True)
+
+    # Map GCS filenames to the local filenames expected by tests
+    secrets_map = {
+        "google-auth-service-account.json": "service_account.json",
+        "google-auth-authorized-user.json": "authorized_user.json",
+        "google-auth-impersonated-service-account.json": "impersonated_service_account.json",
+    }
+
+    gcs_base = "gs://cloud-devrel-kokoro-resources/google-cloud-python"
+
+    for src_name, dest_name in secrets_map.items():
+        subprocess.run(
+            ["gcloud", "storage", "cp", f"{gcs_base}/{src_name}", str(dest_dir)],
+            check=True,
+            capture_output=True,
+        )
+        # Rename to use underscores as per test conventions
+        (dest_dir / src_name).replace(dest_dir / dest_name)
+
+
+_provision_kokoro_secrets()
+
+
 # Cloud SDK helpers
 
 
