Merge pull request googleapis#296 from lucemia/support-null-value

tseaver · tseaver · commit 7d9bfb1d4ef8 · 2014-10-28T12:51:32.000-04:00
googleapis#295 let entity save accept null value for attribute
diff --git a/gcloud/datastore/helpers.py b/gcloud/datastore/helpers.py
@@ -226,6 +226,10 @@ def _set_protobuf_value(value_pb, val):
                :class:`gcloud.datastore.entity.Entity`,
     :param val: The value to be assigned.
     """
+    if val is None:
+        value_pb.Clear()
+        return
+
     attr, val = _get_protobuf_attribute_and_value(val)
     if attr == 'key_value':
         value_pb.key_value.CopyFrom(val)
diff --git a/gcloud/datastore/test_helpers.py b/gcloud/datastore/test_helpers.py
@@ -363,6 +363,25 @@ def test_key(self):
         value = pb.key_value
         self.assertEqual(value, key.to_protobuf())
 
+    def test_none(self):
+        from gcloud.datastore.entity import Entity
+
+        entity = Entity()
+        pb = self._makePB()
+
+        self._callFUT(pb, False)
+        self._callFUT(pb, 3.1415926)
+        self._callFUT(pb, 42)
+        self._callFUT(pb, (1 << 63) - 1)
+        self._callFUT(pb, 'str')
+        self._callFUT(pb, b'str')
+        self._callFUT(pb, u'str')
+        self._callFUT(pb, entity)
+        self._callFUT(pb, [u'a', 0, 3.14])
+
+        self._callFUT(pb, None)
+        self.assertEqual(len(pb.ListFields()), 0)
+
     def test_bool(self):
         pb = self._makePB()
         self._callFUT(pb, False)
