-
Notifications
You must be signed in to change notification settings - Fork 258
UPD: Always put files with empty field at the end of filelist when sortin… #1878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Will the sorting direction be taken into account or not? |
|
In this patch no. |
|
It doesn't seem very convenient. |
|
my pov: when sort by plugin value personnaly iam only interested in files with result. currently when comparing strings, files with empty values always jump to the beginning/end of the list and if the list is big you need to spend more time scrolling to the appropriate files |
|
But an empty value is also a result. |
|
welp when i sort by lets say title/page count in a pdf, personally the last thing i want to see is txt files or images at the top of the list regardless of sort direction |
|
Hmm. I tried using it and I'm not sure it's better. (And the optional parameter will probably "eat" up a lot of time...) |
|
are there issues in some usecase or is it just a matter of habit? |
|
When I change the sort direction, I expect a certain result at the top or bottom of the list. P.S. The difference from sorting by extension, if there are files without an extension, is a bit unexpected. |
|
empty != incorrect, nil is returned in line 52, which is equivalent to the error code ft_fileerror/ft_fieldempty in c plugins. try returning "", but welp i can also add option in the config if this realy necessary |
|
I made a mistake, I used
Won't that slow it down too much? |
|
i think its just a weird issue with comparing a string to null, this shouldnt happen with this patch its just an extra boolean comparison in the condition, but ideally id like to go without it if its not necessary also thought maybe for incorrect files in the list it should show instead of an empty string eg ?? so that they could be distinguished, but in reality thats a bit annoying with regular font/color |
I don't know, I don't really understand the implications in the long run, so I opened my mouth :))
Not very good idea, nothing is nothing. I think this is the plugin's job. |
|
dont quite get what you mean by the plugin job because it did its job when it returned the result. atm w/o clear indication nothing is both an empty string and an incorrect file. while with patch, eg when sorting by album with audioinfo.wdx, audio files with an empty tag will be sorted, and covers, lyrics, playlists or just some other random crap will always be at the bottom. from my pov, its more convenient this way, but dunno w/o clear indication, questions may arise about why exacly this happens can you check how other commanders behave on win when you have time? tried adding audioinfo.wdx on wine, but it doesnt show up in the plugin list for some reason when i create a columnset |
I mean that the program shouldn't add "??" or anything like that.
But if you are looking for files with an empty tag, it is less convenient :)
TC and DC behave the same way.
Check the list of dependencies, I saw |
erm, you mean when you search for files with an empty tag to fill them its more convenient to have the incorrect files sorted in one pile? again, with the patch files with an empty tag are sorted as strings. |
If I use Maybe I'm a little stupid or maybe I don't fully understand how it should work or maybe I don't understand how convenience in some particular case would be convenient in all cases :)) P.S. I forgot to ask, else if VarIsType(Value1, varString) and not VarIsClear(Value2) thenwhy is the second part of the condition added? |
|
it will be more practical to just test it more and provide feedback on how and when it is inconvenient in your workflow tbh im starting to get the impression that im just increasing the comment counter by repeating the same thing: additional condition added since the patch is now optional and disabled by default, so that the clean variant doesnt give undefined results(when sort presed several times) when passed to CompareString, that you mentioned on the forum |
Yesterday (again). DC alpha, DC from your branche, TC + audioinfo & TCMediaInfo, poppler_info & xPDFSearch (1.11); folders with homogeneous content and not. |
…g by plugins