Skip to content

Updated McMaster.Extensions.CommandLineUtils to 3.0.0#640

Merged
filipw merged 4 commits into
dotnet-script:masterfrom
badbort:mcmaster-update-3.0.0
Feb 4, 2022
Merged

Updated McMaster.Extensions.CommandLineUtils to 3.0.0#640
filipw merged 4 commits into
dotnet-script:masterfrom
badbort:mcmaster-update-3.0.0

Conversation

@badbort
Copy link
Copy Markdown
Contributor

@badbort badbort commented Sep 9, 2021

Updated the command line utils package.

I have done this as my .csx scripts pull a package that references a more recent version of McMaster.Extensions.CommandLineUtils. This causes the script to fail:

FileLoadException:Could not load file or assembly 'McMaster.Extensions.CommandLineUtils, Version=3.0.0.0, Culture=neutral, PublicKeyToken=6f71cb76b82f055d'. Could not find or load a specific file. (0x80131621)
at Microsoft.Extensions.Hosting.HostBuilderExtensions.RunCommandLineApplicationAsync[TApp](IHostBuilder hostBuilder, String[] args, CancellationToken cancellationToken)
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Microsoft.Extensions.Hosting.HostBuilderExtensions.RunCommandLineApplicationAsync[TApp](IHostBuilder hostBuilder, String[] args, CancellationToken cancellationToken)
at Indi.UpdateIndex.WebJob.Program.Main(String[] args)

I have tried downgrading the referenced package to 2.2.5 but that version has some issues.

This does highlight an issue where dotnet-script dependencies conflict with the .csx nuget dependencies, however I figure this is a harmless upgrade that allows me to proceed in the short term

@filipw
Copy link
Copy Markdown
Member

filipw commented Sep 9, 2021

did you try running your script with --isolated-load-context? e.g. dotnet script main.csx --isolated-load-context

filipw
filipw approved these changes Sep 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@badbort
Copy link
Copy Markdown
Contributor Author

badbort commented Sep 9, 2021

Ah, I did not notice that option. I'll give that a shot

Cheers

@badbort badbort closed this Sep 9, 2021
@badbort badbort reopened this Sep 9, 2021
@badbort
Copy link
Copy Markdown
Contributor Author

badbort commented Sep 9, 2021

Sorry not too familiar with completing PRs in github. Do I leave this in your hands now for merging?

@filipw filipw enabled auto-merge February 4, 2022 10:28
@filipw filipw merged commit 114aed0 into dotnet-script:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seesharper seesharper seesharper approved these changes

@filipw filipw filipw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@badbort @filipw @seesharper