Skip to content

Conversation

@KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented Aug 14, 2025

Fixes #13805

  • Removes the ExperimentalAttribute for all Dark Mode (SetColorMode) related APIs.
  • Updates the docs for Application.SetColorMode to reflect latest developments.
  • Removes #Pragma 5001
Microsoft Reviewers: Open in CodeFlow

@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner August 14, 2025 18:50
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label Aug 14, 2025
@KlausLoeffelmann KlausLoeffelmann self-assigned this Aug 14, 2025
@KlausLoeffelmann KlausLoeffelmann force-pushed the DarkModeRemoveExperimental branch from c7c791b to 238399a Compare August 14, 2025 18:55
@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.08703%. Comparing base (8a44096) to head (96cd8b1).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13810          +/-   ##
====================================================
+ Coverage   51.89464%   77.08703%   +25.19238%     
====================================================
  Files           2064        3272        +1208     
  Lines         287812      644469      +356657     
  Branches       42098       47673        +5575     
====================================================
+ Hits          149359      496802      +347443     
- Misses        135565      143966        +8401     
- Partials        2888        3701         +813     
Flag Coverage Δ
Debug 77.08703% <ø> (+25.19238%) ⬆️
integration 18.99260% <ø> (-0.00071%) ⬇️
production 51.89950% <ø> (+0.00486%) ⬆️
test 97.41264% <ø> (?)
unit 49.34332% <ø> (+0.03717%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

/// <para>
/// Note that the dark color mode is only available from Windows 11 on or later versions. If the system
/// is set to a high contrast mode, the dark mode is not available.
/// Note that Dark Mode is only available on Windows 11 and later. If Windows is set to High Contrast mode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New naming for Win11 is if a "contrast theme" is applied under accessibility settings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good to know!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a replace through out, while I was at it.
Also in most of the commments.

@dotnet-policy-service dotnet-policy-service bot added waiting-author-feedback The team requires more information from the author and removed waiting-author-feedback The team requires more information from the author labels Aug 14, 2025
@KlausLoeffelmann KlausLoeffelmann force-pushed the DarkModeRemoveExperimental branch from 644e36f to fab45b1 Compare August 15, 2025 03:19
@KlausLoeffelmann KlausLoeffelmann force-pushed the DarkModeRemoveExperimental branch from 9a883a9 to c12911e Compare August 15, 2025 03:38
Co-authored-by: Merrie McGaw <mmcgaw@microsoft.com>
Copy link
Member

@merriemcgaw merriemcgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KlausLoeffelmann !!

@KlausLoeffelmann KlausLoeffelmann merged commit 687601b into dotnet:main Aug 15, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-DarkMode Issues relating to Dark Mode feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove experimental state for DarkMode

2 participants