-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove Experimental attribute for dark mode #13810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Experimental attribute for dark mode #13810
Conversation
c7c791b to
238399a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13810 +/- ##
====================================================
+ Coverage 51.89464% 77.08703% +25.19238%
====================================================
Files 2064 3272 +1208
Lines 287812 644469 +356657
Branches 42098 47673 +5575
====================================================
+ Hits 149359 496802 +347443
- Misses 135565 143966 +8401
- Partials 2888 3701 +813
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
src/System.Windows.Forms/System/Windows/Forms/Controls/TreeView/TreeView.cs
Show resolved
Hide resolved
| /// <para> | ||
| /// Note that the dark color mode is only available from Windows 11 on or later versions. If the system | ||
| /// is set to a high contrast mode, the dark mode is not available. | ||
| /// Note that Dark Mode is only available on Windows 11 and later. If Windows is set to High Contrast mode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New naming for Win11 is if a "contrast theme" is applied under accessibility settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good to know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a replace through out, while I was at it.
Also in most of the commments.
644e36f to
fab45b1
Compare
…lication.SetColorMode.
Fix merge issue.
9a883a9 to
c12911e
Compare
Co-authored-by: Merrie McGaw <mmcgaw@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KlausLoeffelmann !!
Fixes #13805
Application.SetColorModeto reflect latest developments.Microsoft Reviewers: Open in CodeFlow