[browser] Library mode without workload #122607
Draft
+27
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
Member
Author
|
@copilot This test variant |
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Dec 17, 2025
) # Description The `LibraryMode` test variant with `useWasmSdk: False, isPublish: True` is expected to fail, but the test was asserting success for all variants. Updated test to set `ExpectSuccess: false` when publishing without WASM SDK, verifying the operation exits with code 1 as expected. ```csharp // Publishing without WASM SDK is expected to fail bool expectSuccess = useWasmSdk || !isPublish; if (isPublish) PublishProject(info, config, new PublishOptions(AssertAppBundle: useWasmSdk, ExpectSuccess: expectSuccess)); else BuildProject(info, config, new BuildOptions(AssertAppBundle: useWasmSdk, ExpectSuccess: expectSuccess)); ``` # Customer Impact No customer impact - test-only change. # Regression No. Test was incomplete, not validating the expected failure scenario. # Testing Test compiles successfully. The updated test will properly validate all four variants: - Build without SDK: succeeds - Build with SDK: succeeds - Publish with SDK: succeeds - Publish without SDK: **fails** (now correctly validated) # Risk Minimal - test-only change with no production code impact. <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
This was referenced Dec 18, 2025
Member
Author
|
The problem is when a library has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building
OutputType=libraryas WebAssembly application doesn't need a workload to be installed.This PR moves the target that configures ILLink from workload to Wasm SDK.