Fix for #18433 (internal error during xml comment processing) #18436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
❗ Release notes required
|
psfinaki
reviewed
Apr 2, 2025
psfinaki
approved these changes
Apr 2, 2025
T-Gro
approved these changes
Apr 3, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18433
Remarks
Initially, I wanted to replace the internal error by a warning.
However, the internal error only occurs
#lineand triple-slash///comments #18433, where you are not interested in the xml comment, orSo, I settled for just ignoring the repeated xml comments for the same line.
Note that an xml comment will be lost only if it is (according to the line directives) on the same line as another one AND it is different from the other one. Which really does not make sense for any of the scenarios that line directives are meant for.
(Also, implemention-wise, getting to the range for a warning would have been quite complicated.)
Checklist