Skip to content

Allow calling method with both Optional and ParamArray #16688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0101 merged 3 commits into from
Feb 12, 2024
Merged

Allow calling method with both Optional and ParamArray #16688

0101 merged 3 commits into from
Feb 12, 2024

Conversation

@ijklam
Copy link
Contributor

@ijklam ijklam commented Feb 11, 2024 •
edited
Loading

Description

Fixes fsharp/fslang-suggestions#1120 by removing the last ParamArray arg out of optional/out params check

图片

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@ijklam ijklam marked this pull request as ready for review February 11, 2024 08:45
@ijklam ijklam requested a review from a team as a code owner February 11, 2024 08:45
T-Gro
T-Gro approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be considered a bugfix.

psfinaki
psfinaki reviewed Feb 12, 2024
View reviewed changes
@0101 0101 merged commit 921ec7c into dotnet:main Feb 12, 2024
@dotnet-bot dotnet-bot mentioned this pull request Feb 29, 2024
Closed
@ijklam ijklam deleted the fix-suggestions-1120 branch June 4, 2024 18:19
@edgarfgp edgarfgp mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Interop with C# method with optional argument and params

4 participants

@ijklam @psfinaki @T-Gro @0101