Checker: report environment before checking namespace

auduchinok · auduchinok · commit bcad6fa507ac · 2025-05-26T14:27:26.000+02:00
diff --git a/src/Compiler/Checking/CheckDeclarations.fs b/src/Compiler/Checking/CheckDeclarations.fs
@@ -5429,6 +5429,8 @@ let rec TcModuleOrNamespaceElementNonMutRec (cenv: cenv) parent typeNames scopem
           let envNS = LocateEnv kind.IsModule cenv.thisCcu env enclosingNamespacePath
           let envNS = ImplicitlyOpenOwnNamespace cenv.tcSink g cenv.amap m enclosingNamespacePath envNS
 
+          CallEnvSink cenv.tcSink (scopem, envNS.NameEnv, env.eAccessRights)
+
           let modTyNS = envNS.eModuleOrNamespaceTypeAccumulator.Value
           let modTyRoot, modulNSs = BuildRootModuleType enclosingNamespacePath envNS.eCompPath modTyNS
           let modulNSOpt = List.tryHead modulNSs
diff --git a/tests/FSharp.Compiler.Service.Tests/CompletionTests.fs b/tests/FSharp.Compiler.Service.Tests/CompletionTests.fs
@@ -13,11 +13,17 @@ let getCompletionInfo source =
 let getCompletionItemNames (completionInfo: DeclarationListInfo) =
     completionInfo.Items |> Array.map (fun item -> item.NameInCode)
 
-let assertHasItemWithNames names (completionInfo: DeclarationListInfo) =
+let private assertItemsWithNames contains names (completionInfo: DeclarationListInfo) =
     let itemNames = getCompletionItemNames completionInfo |> set
 
     for name in names do
-        Assert.True(Set.contains name itemNames, $"{name} not found in {itemNames}")
+        Assert.True(Set.contains name itemNames = contains)
+
+let assertHasItemWithNames names (completionInfo: DeclarationListInfo) =
+    assertItemsWithNames true names completionInfo
+
+let assertHasNoItemsWithNames names (completionInfo: DeclarationListInfo) =
+    assertItemsWithNames false names completionInfo
 
 [<Fact>]
 let ``Expr - After record decl 01`` () =
@@ -353,4 +359,24 @@ module rec M =
 
     let _: R{caret} = ()
 """
-    assertHasItemWithNames ["Rec1"; "Rec2"; "Rec3"] info
+    assertHasItemWithNames ["Rec1"; "Rec2"; "Rec3"] info
+
+[<Fact>]
+let ``Not in scope 01`` () =
+    let info =
+        getCompletionInfo """
+namespace Ns1
+
+type E =
+    | A = 1
+    | B = 2
+    | C = 1
+
+namespace Ns2
+
+module Module =
+    match Ns1.E.A with
+    | {caret}
+
+"""
+    assertHasNoItemsWithNames ["E"] info
