Skip to content

[rc2] Update MSBuild and Roslyn dependencies to sim-ship versions#36707

Merged
AndriySvyryd merged 1 commit intorelease/10.0from
UpdateRoslyn
Sep 4, 2025
Merged

[rc2] Update MSBuild and Roslyn dependencies to sim-ship versions#36707
AndriySvyryd merged 1 commit intorelease/10.0from
UpdateRoslyn

Conversation

@AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Sep 4, 2025

This is part of the effort to simplify our dependency versioning and support policies

cc @artl93

@AndriySvyryd AndriySvyryd requested a review from a team September 4, 2025 00:50
@cincuranet
Copy link
Contributor

cincuranet commented Sep 4, 2025

FYI the failure is:

Precompilation error: System.ArgumentException: Expression of type 'System.Int32[]' cannot be used for parameter of type 'System.ReadOnlySpan`1[System.Int32]' of method 'Boolean Contains[Int32](System.ReadOnlySpan`1[System.Int32], Int32)' (Parameter 'arg0')\n   at System.Linq.Expressions.Expression.Call(Expression instance, MethodInfo method, Expression arg0, Expression arg1)\n   at System.Linq.Expressions.Expression.Call(Expression instance, MethodInfo method, IEnumerable`1 arguments)\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.VisitInvocationExpression(InvocationExpressionSyntax invocation) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 727\n   at Microsoft.CodeAnalysis.CSharp.CSharpSyntaxVisitor`1.Visit(SyntaxNode node)\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.Visit(SyntaxNode node) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 124\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.VisitLambdaExpression(AnonymousFunctionExpressionSyntax lambda, Type expectedType) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 1087\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.Visit(SyntaxNode node, Type expectedType) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 146\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.VisitArgument(ArgumentSyntax argument, Type expectedType) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 223\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.Visit(SyntaxNode node, Type expectedType) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 142\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.VisitInvocationExpression(InvocationExpressionSyntax invocation) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 717\n   at Microsoft.CodeAnalysis.CSharp.CSharpSyntaxVisitor`1.Visit(SyntaxNode node)\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.Visit(SyntaxNode node) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 124\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.VisitInvocationExpression(InvocationExpressionSyntax invocation) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 571\n   at Microsoft.CodeAnalysis.CSharp.CSharpSyntaxVisitor`1.Visit(SyntaxNode node)\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.Visit(SyntaxNode node) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 124\n   at Microsoft.EntityFrameworkCore.Query.Internal.CSharpToLinqTranslator.Translate(SyntaxNode node, SemanticModel semanticModel) in /_/src/EFCore.Design/Query/Internal/CSharpToLinqTranslator.cs:line 110\n   at Microsoft.EntityFrameworkCore.Query.Internal.PrecompiledQueryCodeGenerator.ProcessSyntaxTree(SyntaxTree syntaxTree, SemanticModel semanticModel, IReadOnlyList`1 locatedQueries, List`1 precompilationErrors, String suffix, ISet`1 generatedFileNames, CancellationToken cancellationToken) in /_/src/EFCore.Design/Query/Internal/PrecompiledQueryCodeGenerator.cs:line 158
   at Microsoft.EntityFrameworkCore.TestUtilities.PrecompiledQueryTestHelpers.FullSourceTest(String sourceCode, DbContextOptions dbContextOptions, Type dbContextType, Action`1 interceptorCodeAsserter, Action`1 errorAsserter, ITestOutputHelper testOutputHelper, Boolean alwaysPrintGeneratedSources, String callerName) in /_/test/EFCore.Relational.Specification.Tests/TestUtilities/PrecompiledQueryTestHelpers.cs:line 124
   at Microsoft.EntityFrameworkCore.TestUtilities.PrecompiledQueryTestHelpers.FullSourceTest(String sourceCode, DbContextOptions dbContextOptions, Type dbContextType, Action`1 interceptorCodeAsserter, Action`1 errorAsserter, ITestOutputHelper testOutputHelper, Boolean alwaysPrintGeneratedSources, String callerName) in /_/test/EFCore.Relational.Specification.Tests/TestUtilities/PrecompiledQueryTestHelpers.cs:line 133
--- End of stack trace from previous location ---

artl93
artl93 approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC2

@AndriySvyryd AndriySvyryd merged commit 33ae58b into release/10.0 Sep 4, 2025
7 checks passed
@AndriySvyryd AndriySvyryd deleted the UpdateRoslyn branch September 4, 2025 22:45
@dibarbet dibarbet mentioned this pull request Sep 10, 2025
Closed
3 tasks
@dibarbet
Copy link
Member

dibarbet commented Sep 10, 2025 •
edited
Loading

@AndriySvyryd is this change absolutely required? Typically Roslyn packages are not published by the VMR (though this may change soon). We only publish on VS releases and aren't part of VMR stablization, so these packages will never get published to nuget.org and therefore will not restore correctly when released.

See also dotnet/sdk#50697

@dibarbet dibarbet mentioned this pull request Sep 10, 2025
Closed
@AndriySvyryd AndriySvyryd mentioned this pull request Sep 11, 2025
Merged
@AndriySvyryd AndriySvyryd mentioned this pull request Nov 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roji roji roji approved these changes

@artl93 artl93 artl93 approved these changes

@cincuranet cincuranet Awaiting requested review from cincuranet cincuranet is a code owner

Assignees

No one assigned

Labels

tell-mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AndriySvyryd @cincuranet @dibarbet @roji @artl93