Support download of 1xx from internal storage #3219
Conversation
| DownloadArchive "source-built SDK" "PrivateSourceBuiltSdkVersion" false "${{ parameters.artifactsRid }}" "$(sourcesPath)/prereqs/packages/archive/" | ||
| displayName: Download Previously Source-Built SDK | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: |
There was a problem hiding this comment.
This should be unnecessary. The template doesn't do anything if the project is public
eng/download-source-built-archive.sh
Outdated
| baseUrl="https://ci.dot.net/public/source-build" | ||
| # Determine CI location based on version suffix | ||
| if [[ $isServicingArchiveVersion == true ]]; then | ||
| baseUrl="https://ci.dot.net/internal/source-build" |
There was a problem hiding this comment.
Is it correct to assume that the SB archive will always be on internal? Typically, what we've done is pass in alternate storage paths+creds to the download functionality. The download code then attempts to first find the asset on public storage, falling back to internal with auth if it gets a 404.
I prefer this approach in general because it has fewer issues at boundary times.
eng/download-source-built-archive.sh
Outdated
|
|
||
| local isServicingArchiveVersion=false | ||
| if [[ "$archiveVersion" == *"servicing"* ]]; then | ||
| isServicingArchiveVersion=true |
There was a problem hiding this comment.
I wouldn't assume location based on servicing or not. An RC might be internal too, for instance. Instead, I'd use an approach where we look in a default public location first, then go to an alternate provided location after that.
2 participants
Fixes dotnet/source-build#5342
download-source-built-archive.shto take the encoded storage key that can be used to access the internal blob storage location.servicinglabel.enable-internal-runtimes.ymltemplate from Arcade which dynamically creates a SAS token and sets it to thedotnetbuilds-internal-container-read-token-base64variable.