Skip to content

[main] Source code updates from dotnet/roslyn #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

[main] Source code updates from dotnet/roslyn #3147

wants to merge 20 commits into from
+43,376 −6,775

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 29, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/roslyn

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 29, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 29, 2025

Important

There are conflicts with the main branch in this PR.
Apart from conflicts in the source files, this means there are unresolved conflicts in the codeflow metadata file src/source-manifest.json.
When resolving these, please use the (incoming/ours) version from the PR branch. The correct content should be this:

{
  "barId": 288936,
  "path": "roslyn",
  "remoteUri": "https://github.com/dotnet/roslyn",
  "commitSha": "d4a697d01ea70799b5dd603ffff005dfb176253a"
}

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@jjonescz jjonescz mentioned this pull request Oct 29, 2025
Closed
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 30, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@jjonescz
Copy link
Member

jjonescz commented Oct 30, 2025

@tmat

  /__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/HotReload/CompilationHandler.cs(9,45): error CS0234: The type or namespace name 'Watch' does not exist in the namespace 'Microsoft.CodeAnalysis.ExternalAccess' (are you missing an assembly reference?) [/__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]
  /__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/HotReload/IncrementalMSBuildWorkspace.cs(7,45): error CS0234: The type or namespace name 'Watch' does not exist in the namespace 'Microsoft.CodeAnalysis.ExternalAccess' (are you missing an assembly reference?) [/__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]
  /__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/HotReload/CompilationHandler.cs(229,32): error CS0246: The type or namespace name 'WatchHotReloadService' could not be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]
  /__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/HotReload/CompilationHandler.cs(294,65): error CS0246: The type or namespace name 'WatchHotReloadService' could not be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]
  /__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/HotReload/CompilationHandler.cs(342,53): error CS0246: The type or namespace name 'WatchHotReloadService' could not be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]
  /__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/HotReload/CompilationHandler.cs(342,124): error CS0246: The type or namespace name 'WatchHotReloadService' could not be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]
  /__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/HotReload/CompilationHandler.cs(632,103): error CS0246: The type or namespace name 'WatchHotReloadService' could not be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]
  /__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/HotReload/CompilationHandler.cs(20,26): error CS0246: The type or namespace name 'WatchHotReloadService' could not be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]
  /__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/HotReload/CompilationHandler.cs(39,31): error CS0246: The type or namespace name 'WatchHotReloadService' could not be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 31, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 1, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 2, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@jjonescz
Copy link
Member

jjonescz commented Nov 3, 2025

Talked to @tmat offline; needs sdk changes from 10.0.2xx to flow into sdk main first (dotnet/sdk#51207)
In the meantime, roslyn main should flow to 10.0.2xx of vmr anyway (although that seems to be waiting on #3162)

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 4, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@jjonescz
Copy link
Member

jjonescz commented Nov 4, 2025

needs sdk changes from 10.0.2xx to flow into sdk main first

I assume also dotnet/sdk#51540 is needed since the original was quite old

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 5, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

.NET Unified Build
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jjonescz