Skip to content

Update ca1863.md #38488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gewarren merged 1 commit into from
Nov 29, 2023
Merged

Update ca1863.md #38488

gewarren merged 1 commit into from
Nov 29, 2023

Conversation

@gurustron
Copy link
Contributor

@gurustron gurustron commented Nov 29, 2023 •
edited by github-actions bot
Loading

  1. Make snippets runnable
  2. I would argue changing the static field type is more real life fix because you can an actually do something like:
class C1
{
    private static readonly string StaticField = "Format one value: {0}";

    static void Main()
    {
        _ = string.Format(null, CompositeFormat.Parse(StaticField), 42);

        StringBuilder sb = new();
        sb.AppendFormat(null, CompositeFormat.Parse(StaticField), 42);
    }
}

Which obviously makes the warning to go away but does not actually cover the underlying issue.

Internal previews

📄 File 🔗 Preview link
docs/fundamentals/code-analysis/quality-rules/ca1863.md CA1863: Use 'CompositeFormat'

@gurustron gurustron requested a review from gewarren as a code owner November 29, 2023 12:35
@dotnet-bot dotnet-bot added this to the November 2023 milestone Nov 29, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Nov 29, 2023
gewarren
gewarren approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gurustron

@gewarren gewarren merged commit b7e8a65 into dotnet:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarren gewarren gewarren approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Milestone

November 2023

Development

Successfully merging this pull request may close these issues.

3 participants

@gurustron @gewarren @dotnet-bot