Skip to content

Conversation

@ErykKorzeniowski
Copy link
Contributor

@ErykKorzeniowski ErykKorzeniowski commented Jul 12, 2023

Summary

Added documentation for required and init keywords.

Fixes #35014


Internal previews

📄 File 🔗 Preview link
docs/csharp/programming-guide/classes-and-structs/object-and-collection-initializers.md Object and Collection Initializers (C# Programming Guide)

@dotnet-bot dotnet-bot added this to the July 2023 milestone Jul 12, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Jul 12, 2023
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ErykKorzeniowski

This is a great addition. I had a number of comments based on our style guide. Let me know what you think, and once we resolve these discussions, this is ready to merge.

ErykKorzeniowski and others added 5 commits July 14, 2023 15:53
…ollection-initializers.md

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
…ollection-initializers.md

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
…ollection-initializers.md

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
…ollection-initializers.md

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
…ollection-initializers.md

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
@ErykKorzeniowski
Copy link
Contributor Author

@BillWagner, I loved your comments! Thank you, in the future, I will do more 2nd person speech!

@BillWagner
Copy link
Member

Thanks for making the updates @ErykKorzeniowski

The warning is unrelated, so I'll :shipit: now.

@BillWagner BillWagner merged commit 0c13b51 into dotnet:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc fundamentals/subsvc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The article on Object and Collection Initializers should mention and explain benefits of init and required.

3 participants