Include name of argument when an argument is missing#2747
Open
samblackburn wants to merge 3 commits intodotnet:mainfrom
Open
Include name of argument when an argument is missing#2747samblackburn wants to merge 3 commits intodotnet:mainfrom
samblackburn wants to merge 3 commits intodotnet:mainfrom
Conversation
Author
|
@dotnet-policy-service agree company="Redgate Software Ltd" |
samblackburn
force-pushed
the
missing-argument
branch
from
8c5ca2c to
7549ee9
Compare
jonsequitur
reviewed
Jan 13, 2026
samblackburn
force-pushed
the
missing-argument
branch
from
04f3739 to
0ebcb38
Compare
jonsequitur
approved these changes
Jan 21, 2026
KalleOlaviNiemitalo
suggested changes
Jan 22, 2026
| internal static string RequiredArgumentMissing(ArgumentResult argumentResult) => | ||
| argumentResult.Parent is CommandResult commandResult | ||
| ? GetResourceString(Properties.Resources.CommandRequiredArgumentMissing, commandResult.IdentifierToken.Value) | ||
| ? GetResourceString(Properties.Resources.CommandRequiredArgumentMissing, argumentResult.Argument.Name, commandResult.IdentifierToken.Value) |
There was a problem hiding this comment.
I think it should be HelpName rather than Name
samblackburn
force-pushed
the
missing-argument
branch
from
b2c4e90 to
faa83ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1074
Reimplementation of #1993 which went quiet in 2023 and now has a ton of merge conflicts.
AI disclaimer: I made this PR while playing with Claude Code.
While the Latin languages look correct to me, I haven't verified the other translations.