Open
Conversation
Motivation:
- Inside custom middleware, it may be desirable to understand relative order of symbols in the parsed command line (for e.g. in the case of several option types that influence a shared setting and that have a "last option specified wins" semantic).
- Best way to do understand sequence order is by inspecting the `ParseResult.Tokens` list. This gives `Token`s, which contain embedded symbol references.
- From there, we'd like to compare the token's `Symbol` directly against predefined `Argument` and `Option` objects to ease identification.
- Doing this from non-`internal` code today requires something like `if (tokenOfInterest == new Token(tokenOfInterest.Value, TokenType.Option, optionOfInterest)) { /* match */ ... }`, which works because of the overridden `Token.Equals` method.
- It'd be much easier to say `if (tokenOfInterest.Symbol == optionOfInterest) { /* match */ ... }`
- No clear reason why `Token.Symbol` needs to be `internal`
|
This might simplify the redaction that I do in #1795. |
Contributor
|
While this might be a useful API addition, it was added primarily for internal bookkeeping and it would need to be tested more thoroughly for a number of scenarios including cases where the token is shifted during parsing, i.e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
ParseResult.Tokenslist. This givesTokens, which contain embedded symbol references.Symboldirectly against predefinedArgumentandOptionobjects to ease identification.internalcode today requires something likeif (tokenOfInterest == new Token(tokenOfInterest.Value, TokenType.Option, optionOfInterest)) { /* match */ ... }, which works because of the overriddenToken.Equalsmethod.if (tokenOfInterest.Symbol == optionOfInterest) { /* match */ ... }Token.Symbolneeds to beinternal