Conversation
HurricanKai
approved these changes
Oct 17, 2021
Perksey
requested changes
Oct 17, 2021
Silk.NET.Maths.sln
Outdated
| @@ -0,0 +1,37 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
Member
There was a problem hiding this comment.
Why are we adding a sln file just for maths?
Member
There was a problem hiding this comment.
Oh it says in the description... I think I disagree with this, and if there is a need for this it should be:
- configurable
- baked into NUKE
- gitignored
I don't want 14 sln files in the repo...
Perksey
approved these changes
Oct 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added solution file for Maths (three projects) to make smoother the experience for those who just want to edit those (it might be a good idea to add a solution file for each set of projects which are more or less independently edited).
And added missing license headers. Closes #634