This is the October 2021 Update (v2.9.0)#628
Conversation
|
In case it's not obvious by the "draft" status: this is not ready for review. |
|
This is now ready for review. Meaningful changes are in src/Core/Silk.NET.BuildTools and src/Core/Silk.NET.Core |
| sw.WriteLine($" public ref {field.Type} {field.Name}"); | ||
| sw.WriteLine(" {"); | ||
| sw.WriteLine(" [MethodImpl((MethodImplOptions) 768)]"); | ||
| sw.WriteLine($" get => ref MemoryMarshal.CreateSpan(ref {args[1]}, 1)[0].{args[2]};"); |
There was a problem hiding this comment.
Pre-emptive response to a potential review comment: the old code that was in the NS21+ branch didn't actually compile, and we never spotted it because for some reason the DirectX projects were NS20 only.
HurricanKai
left a comment
HurricanKai
left a comment
There was a problem hiding this comment.
I can't push out the update this night anyways, and there are some issues regarding naming which we can't fix without breaking.
| sw.WriteLine($" public ref {field.Type} {field.Name}"); | ||
| sw.WriteLine(" {"); | ||
| sw.WriteLine(" [MethodImpl((MethodImplOptions) 768)]"); | ||
| sw.WriteLine($" get => ref MemoryMarshal.CreateSpan(ref {args[1]}, 1)[0].{args[2]};"); |
There was a problem hiding this comment.
I am missing something here. How is ref CreateSpan(ref x, 1)[0] different from ref x?
There was a problem hiding this comment.
ref x is blocked at a language level
| Arguments = new() | ||
| { | ||
| "SilkTouchStage.Begin", | ||
| $"\"{last.Name} = new({outSType.DefaultAssignment});\"" |
There was a problem hiding this comment.
Technically this can break the same people that removing the broken overloads would've broken, just saying 😛
There was a problem hiding this comment.
The functionality of the overloads are undefined, whereas a function existing is well defined.
| { | ||
| [NativeName("AnonymousName", "__AnonymousEnum_evntrace_L529_C9")] | ||
| [NativeName("Name", "ETW_COMPRESSION_RESUMPTION_MODE")] | ||
| public enum ETWCOMPRESSIONRESUMPTIONMODE : int |
There was a problem hiding this comment.
I can’t make changes to the namer this late on - it’ll 100% change other names as well.
There was a problem hiding this comment.
Well we'd see that in the diff though? If nothing else is possible I will look at the names tomorrow and manually change the ones that are all caps.
2 participants
Uh oh!
There was an error while loading. Please reload this page.