Skip to content

Commit d9684ca

Browse files
committed
create_xpi.py: Set to use argparse variables directly instead of using separate
ones.
1 parent 62f2d38 commit d9684ca

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

utils/create_xpi.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,21 @@
1818
dest="exclusions", metavar="File with file pattern exclusions",
1919
default=".build_exclusions", help="Excluded file patterns.")
2020
parser.add_argument("-n", type=str,
21-
dest="name", help="Name of Zip file.")
21+
dest="xpiname", help="Name of target XPI file.")
2222
parser.add_argument("directory", type=str,
2323
help="Directory to compress.")
2424

2525
args = parser.parse_args()
2626

27-
xpiName = args.name
28-
exclusionsFile = args.exclusions
29-
directory = args.directory
30-
3127
exclusions = []
32-
with open(exclusionsFile) as f:
28+
with open(args.exclusions) as f:
3329
for line in f:
3430
exclusions.extend(glob.glob(line.strip()))
3531
exclusions = map(lambda x: './'+x, exclusions)
3632

3733
compress = zipfile.ZIP_DEFLATED
3834

39-
xpiFile = zipfile.ZipFile(xpiName, mode='w', compression=compress)
35+
xpiFile = zipfile.ZipFile(args.xpiname, mode='w', compression=compress)
4036

41-
xpiFile.write_from_directory(directory, exclusions, compress_type=compress)
37+
xpiFile.write_from_directory(args.directory, exclusions, compress_type=compress)
4238
xpiFile.close()

0 commit comments

Comments
 (0)