hooks/precommit: Properly test for ruleset changes.

jpds-zz · jpds-zz · commit be1d5cbe3cf4 · 2013-10-11T09:32:58.000Z
diff --git a/hooks/precommit b/hooks/precommit
@@ -10,7 +10,9 @@ git stash -q --keep-index
 
 # Only run tests if our rulesets have been changed.
 RULESET_PATTERN="src/chrome/content/rules/"
-if [ $(git diff --cached --name-only | grep "$RULESET_PATTERN") ]; then
+CHANGED_RULESETS="$(git diff --cached --name-only | grep $RULESET_PATTERN)"
+
+if [ "$CHANGED_RULESETS" ]; then
     echo "$(date -R): Running ruleset validation tests on changed rulesets:"
     ./utils/trivial-validate.py $(git diff --cached --name-only) > /dev/null
     RESULT=$?
