Skip to content

Commit 67413bc

Browse files
committed
Revert "[makexpi] Run $VALIDATE in bg"
This reverts commit e0c5cad. Putting validate in the background means that when there is a failure and we call `die`, the `exit 1` gets run in a subshell and so error status does not get returned to the caller of makexpi.sh (i.e. test.sh). Fixes EFForg#671
1 parent 9bbe318 commit 67413bc

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

makexpi.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ if [ "$1" != "--fast" ] ; then
9090
echo >&2
9191
else
9292
die "Validation of rulesets failed."
93-
fi &
93+
fi
9494

9595
# Check for xmllint.
9696
type xmllint >/dev/null || die "xmllint not available"
@@ -108,7 +108,6 @@ if [ "$1" != "--fast" ] ; then
108108
}
109109
if validate_grammar 2>/dev/null
110110
then
111-
wait;
112111
echo Validation of rulesets against $GRAMMAR succeeded. >&2
113112
else
114113
validate_grammar 2>&1 | grep -v validates

0 commit comments

Comments
 (0)