Change to use a string for encoding parameter, for backwards compatibility with node 0.8

jsha · jsha · commit 673924efdead · 2014-01-09T16:49:22.000-08:00
diff --git a/rewriter/rewriter.js b/rewriter/rewriter.js
@@ -47,7 +47,7 @@ function processDir(dir) {
 }
 
 function processFile(filename) {
-  var contents = fs.readFileSync(filename, {encoding: 'utf-8'});
+  var contents = fs.readFileSync(filename, 'utf8');
   var rewrittenFile = URI.withinString(contents, function(url) {
     var uri = new URI(url);
     if (uri.protocol() != 'http') return url;
@@ -74,7 +74,7 @@ function processFile(filename) {
 }
 
 function loadRuleSets() {
-  var fileContents = fs.readFileSync(path.join(__dirname, '../pkg/crx/rules/default.rulesets'), {encoding: 'utf-8'});
+  var fileContents = fs.readFileSync(path.join(__dirname, '../pkg/crx/rules/default.rulesets'), 'utf-8');
   var xml = new DOMParser().parseFromString(fileContents, 'text/xml');
   ruleSets = new rules.RuleSets("fake user agent", lrucache.LRUCache, xml, {});
 }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ function processDir(dir) {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`function processFile(filename) {`
`50`		`- var contents = fs.readFileSync(filename, {encoding: 'utf-8'});`
	`50`	`+ var contents = fs.readFileSync(filename, 'utf8');`
`51`	`51`	`var rewrittenFile = URI.withinString(contents, function(url) {`
`52`	`52`	`var uri = new URI(url);`
`53`	`53`	`if (uri.protocol() != 'http') return url;`
`@@ -74,7 +74,7 @@ function processFile(filename) {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`function loadRuleSets() {`
`77`		`- var fileContents = fs.readFileSync(path.join(__dirname, '../pkg/crx/rules/default.rulesets'), {encoding: 'utf-8'});`
	`77`	`+ var fileContents = fs.readFileSync(path.join(__dirname, '../pkg/crx/rules/default.rulesets'), 'utf-8');`
`78`	`78`	`var xml = new DOMParser().parseFromString(fileContents, 'text/xml');`
`79`	`79`	`ruleSets = new rules.RuleSets("fake user agent", lrucache.LRUCache, xml, {});`
`80`	`80`	`}`