Remove random try/catch

semenko · semenko · commit 18ca9cfba89f · 2015-04-02T22:03:49.000-05:00
Not clear to me what this was catching...

Signed-off-by: Nick Semenkovich &lt;semenko@alum.mit.edu&gt;
diff --git a/chromium/rules.js b/chromium/rules.js
@@ -45,7 +45,7 @@ RuleSet.prototype = {
         return null;
       }
     }
-    // If a rulset has a match_rule and it fails, go no further
+    // If a ruleset has a match_rule and it fails, go no further
     if (this.ruleset_match_c && !this.ruleset_match_c.test(urispec)) {
       log(VERB, "ruleset_match_c excluded " + urispec);
       return null;
@@ -290,16 +290,8 @@ RuleSets.prototype = {
     // If we passed that test, make up a random URL on the domain, and see if
     // we would HTTPSify that.
 
-    try {
-      var nonce_path = "/" + Math.random().toString();
-      nonce_path = nonce_path + nonce_path;
-      var test_uri = "http://" + domain + nonce_path;
-    } catch (e) {
-      log(WARN, "explosion in safeToSecureCookie for " + domain + "\n"
-                      + "(" + e + ")");
-      this.cookieHostCache.set(domain, false);
-      return false;
-    }
+    var nonce_path = "/" + Math.random().toString();
+    var test_uri = "http://" + domain + nonce_path + nonce_path;
 
     log(INFO, "Testing securecookie applicability with " + test_uri);
     var rs = this.potentiallyApplicableRulesets(domain);
