Skip to content

bump: :lang clojure #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bump: :lang clojure #8553

wants to merge 1 commit into from
+3 −3

Conversation

@raszi
Copy link
Contributor

@raszi raszi commented Oct 23, 2025

No description provided.

@raszi raszi changed the title chore: update Clojure packages chore(clojure): update packages Oct 23, 2025
@raszi raszi force-pushed the chore/update-cider branch 2 times, most recently from c246c44 to 989dbf3 Compare October 23, 2025 11:37
@raszi
Copy link
Contributor Author

raszi commented Oct 23, 2025

The lint-commit fails because it does not recognize clojure as a scope. Is that right?

@raszi raszi force-pushed the chore/update-cider branch from 989dbf3 to d05f093 Compare October 23, 2025 16:25
@hlissner hlissner added re:packages Pertains to package & dependency management module:lang/clojure Pertains to Doom's :lang clojure module is:update An effort to catch up with changes made elsewhere labels Oct 25, 2025
@hlissner hlissner added this to the modules v25.11 milestone Oct 25, 2025
hlissner
hlissner requested changes Oct 25, 2025
View reviewed changes
Copy link
Member

@hlissner hlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add clojure-emacs/clojure-mode@28dc02114ae7 -> clojure-emacs/clojure-mode@9b3f84645b1e to 6460422's commit message.

The lint-commit fails because it does not recognize clojure as a scope. Is that right?

Yes, but it's a false positive and can be ignored. Due to work elsewhere, the linter doesn't recognize any module scopes.

hlissner
hlissner requested changes Oct 25, 2025
View reviewed changes
Copy link
Member

@hlissner hlissner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing d05f093? No other module does this, no whitespace style guide exists about it, and I'd rather not make a precedent for folks imposing their own until I can get around to writing one.

@hlissner hlissner changed the title chore(clojure): update packages bump: :lang clojure Oct 25, 2025
@raszi
Copy link
Contributor Author

raszi commented Oct 26, 2025

Would you mind removing d05f093? No other module does this, no whitespace style guide exists about it, and I'd rather not make a precedent for folks imposing their own until I can get around to writing one.

Sure I can do that. Although before I did that change I've checked some other modules with more features and packages to see how readable they are and how they manage the when parts. For e.g.

@raszi raszi force-pushed the chore/update-cider branch from d05f093 to 6460422 Compare October 26, 2025 18:04
@raszi raszi force-pushed the chore/update-cider branch from 6460422 to 5dec33d Compare October 26, 2025 18:05
@raszi
Copy link
Contributor Author

raszi commented Oct 26, 2025

Would you mind removing d05f093?

@hlissner I did that, removed all the whitespace changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hlissner hlissner hlissner requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

is:update An effort to catch up with changes made elsewhere module:lang/clojure Pertains to Doom's :lang clojure module re:packages Pertains to package & dependency management

Projects

None yet

Milestone

modules v25.11

Development

Successfully merging this pull request may close these issues.

2 participants

@raszi @hlissner