Skip to content

fix: rebar3 does not work with fmt -v arguments #8506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: rebar3 does not work with fmt -v arguments #8506

wants to merge 1 commit into from

Conversation

@apostaat
Copy link

@apostaat apostaat commented Sep 14, 2025 •
edited
Loading

Replace this with a summary of what you've changed and why, followed by a list of issues it affects, if any.

Fix: #0000
Ref: #0000
Close: #0000

  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to Doom's git conventions.
  • Any relevant issues or PRs have been linked to.

doom doctor utility raises a warning however the command it tries to invoke does not exist in rebar3
i changed it to proper command call, and added check for erlfmt -v command, changed the text of warnings accordingly

@hlissner hlissner added is:bug Something isn't working as intended module:lang/erlang Pertains to Doom's :lang erlang module labels Sep 14, 2025
@hlissner hlissner added this to the modules v25.10 milestone Sep 14, 2025
@hlissner hlissner moved this from Undecided to Queued for editing in Triage (housekeeping) Sep 14, 2025
@hlissner
Copy link
Member

hlissner commented Sep 14, 2025

Do erlang users need both erlfmt and rebar3 format, for some reason? The module is only configured to recognized the latter.

@apostaat
Copy link
Author

apostaat commented Sep 14, 2025 •
edited
Loading

erlang users need both erlfmt and rebar3 format, for some reason

@hlissner looks like there is no need in both. rebar3 is more popular rather than erlfmt, however it needs to be configured to make it work (rebar3 format does not work from the box, format is a plugin that needs to be installed), while erlfmt installation does not need any configuration by default.

In the piece of code you mentioned we need the same fix probably:

(set-formatter! 'erlfmt '("rebar3" "format")
   :modes '(erlang-mode erlang-ts-mode))

Should I open separate PR for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

is:bug Something isn't working as intended module:lang/erlang Pertains to Doom's :lang erlang module

Projects

Triage (housekeeping)
Status: Queued for editing

Milestone

modules v25.10

Development

Successfully merging this pull request may close these issues.

2 participants

@apostaat @hlissner