This repository was archived by the owner on Mar 11, 2021. It is now read-only.
Open
Conversation
Contributor
Author
There was a problem hiding this comment.
@knowtheory do we need this RuntimeError catch still? Was this exception used to catch errors if Calais received a request that was too large? If so, we have an exception that can handle this.
Member
There was a problem hiding this comment.
@cometman So long as the branch there is covered and that the content too large error is caught through other means we can remove it def.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding error handling to catch Calais errors nicely. This allows us to do different things based on Calais API errors (wait some time, notify the team, etc.)