Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: documentcloud/cloud-crowd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: documentcloud/cloud-crowd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rails4
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 10 files changed
  • 1 contributor

Commits on Sep 23, 2013

  1. Use TEST env var to run single test

    Because sometimes one test is all you can handle.
    nathanstitt committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    c7b434c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bab75e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2013

  1. Remove gems from Gemfile that are in gemspec

    No reason to duplicate them, the gemspec would have priority anyway since
    it appears later in the file
    nathanstitt committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    5121177 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f6d6a0 View commit details
    Browse the repository at this point in the history
  3. Node must call super() to initialize Sinatra::Base

    If it doesn't then Sinatra::Base never initializes the template_cache,
    causing undefined variable exceptions later in it's life-cycle
    nathanstitt committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    71923aa View commit details
    Browse the repository at this point in the history
  4. ActiveSupport no longer has SecureRandom

    It's part of the Ruby stdlib in 1.9
    nathanstitt committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    dd4bae5 View commit details
    Browse the repository at this point in the history
  5. Reserved scope must be array before manipulation

    Otherwise calling delete on it will perform a delete in the database.
    Under ActiveRecord 2.3, records returned from a scope where array-like and a delete just removed
    them from the in-memory representation, not the DB.  Under newer
    ActiveRecord, it's an association so delete also performs a DB delete.
    nathanstitt committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    788e6fa View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2013

  1. Add current directory to LOAD_PATH

    If actions are not an absolute path then they need to be loaded from the
    current directory.
    
    An alternate method would be to convert relative action paths to absolute.
    nathanstitt committed Sep 30, 2013
    Configuration menu
    Copy the full SHA
    3a7fabe View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2013

  1. Set $LOAD_PATH to action_paths

    This way the actions can be required by using their basename
    nathanstitt committed Oct 1, 2013
    Configuration menu
    Copy the full SHA
    765f507 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2013

  1. Configuration menu
    Copy the full SHA
    09e0a6e View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2014

  1. Pull in upstream fixes

    nathanstitt committed Jan 6, 2014
    Configuration menu
    Copy the full SHA
    56a81c2 View commit details
    Browse the repository at this point in the history
Loading