Skip to content

Fix linkerStack resolution order #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmcw merged 1 commit into from
Oct 11, 2016
Merged

Fix linkerStack resolution order #564

tmcw merged 1 commit into from
Oct 11, 2016

Conversation

@tmcw
Copy link
Member

@tmcw tmcw commented Oct 11, 2016

Fixes #563

Question: should custom links in configuration files win out over links to namespaces in documentation? With this PR, they would not - resolution order would be:

  1. Namespace
  2. Configuration
  3. Globals (MDN)

arv
arv approved these changes Oct 11, 2016
View reviewed changes
Copy link
Contributor

@arv arv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arv
Copy link
Contributor

arv commented Oct 11, 2016

I think this order is the right one.

@tmcw tmcw merged commit 7ccf89d into master Oct 11, 2016
@tmcw tmcw deleted the linker-order branch October 11, 2016 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arv arv arv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmcw @arv