Roll this into the main repo? #108

Activity

1. anikethsaha commented on Jun 18, 2020

   

   anikethsaha

   on Jun 18, 2020

   Member

   More actions

   did you mean as a monorepo ?
2. trusktr commented on Jun 18, 2020

   

   trusktr

   on Jun 18, 2020

   Last edited by trusktr

   MemberAuthor

   More actions

   Yeah, like with docsify-server-render
3. anikethsaha commented on Jun 18, 2020

   

   anikethsaha

   on Jun 18, 2020

   Member

   More actions

   Actually I don't really prefer monorepo. It's just because the tools are not so good enough to solve most of the issues.
   F.e releases, with monorepo, doing a release, and generating a changelog was never a comfortable process for me.

   Though I don't mind moving, we may need to change the release script as well.
4. anikethsaha

   added

   needs discussion

   on Jun 18, 2020
5. trusktr commented on Jun 18, 2020

   

   trusktr

   on Jun 18, 2020

   Last edited by trusktr

   MemberAuthor

   More actions

   Another option is an "umbrella repo" as I like to call it: we can make the packages be git submodules. Then they have their own workflow, but the umbrella repo can test them in unison.

   What issues did you have?
6. trusktr commented on Jun 18, 2020

   

   trusktr

   on Jun 18, 2020

   Last edited by trusktr

   MemberAuthor

   More actions

   I've been using th umbrella approach.

   For Example: http://guthub.com/lume/lume.

   See in the packages folder. This repo has its own tests.yml file to test all the sub repos at once and working together (https://github.com/lume/lume/blob/develop/.github/workflows/tests.yml) and see the test script in package.json.

   Then also click into the sub modules, and you'll see they have their own tests too (f.e. https://github.com/lume/element-behaviors/blob/master/.github/workflows/tests.yml) and see that repo's test script in package.json.

   This has a nice advantage: with an umbrella repo (not a monorepo) you get

   • to track the version of all projects in the state that they all work together (difficult to do with individual repos)
   • test everything all at once
   • Plus! Because each package is its own repo, you can still clone it and work with it like you would any other repo, it is fully independent.
   • Furthermore, because each package is also an independent repo, it can be installed from git (and any other benefits of independent repos)
7. trusktr commented on Jun 18, 2020

   

   trusktr

   on Jun 18, 2020

   MemberAuthor

   More actions

   Though don't mind moving, we may need to change the release script as wel.

   Yeah, it'll involve some changes