buble theme: fix strong font-weight increased to 600 (onto master branch)#952
Merged
anikethsaha merged 1 commit intodocsifyjs:masterfrom Dec 3, 2019
xmedeko:buble-patch-2
Merged
buble theme: fix strong font-weight increased to 600 (onto master branch)#952anikethsaha merged 1 commit intodocsifyjs:masterfrom xmedeko:buble-patch-2
anikethsaha merged 1 commit intodocsifyjs:masterfrom
xmedeko:buble-patch-2
Conversation
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #913 for the debate. TLDR:
I've separated strong and set it to 600. I've removed the
a { font-weight: 400}, because it has overridden the headings h1, ... font-weight below.(Links has blue color in the buble theme, so they do not need the slight font-weight increase. I also do not know how to keep font-weight and do not override headings, because headings are links to. I aware of CSS !important, but I think this solution is better for this situation.)