Skip to content

Fix #865#867

Merged
anikethsaha merged 1 commit intodocsifyjs:developfrom
aenniw:bug/865
Mar 9, 2020
Merged

Fix #865#867
anikethsaha merged 1 commit intodocsifyjs:developfrom
aenniw:bug/865

Conversation

@aenniw
Copy link
Contributor

@aenniw aenniw commented Jun 8, 2019 •
edited by anikethsaha
Loading

fixes #865

Signed-off-by: Martin Mihálek aenniw@gmail.com

Summary

Added relative to absolute path resolving in embeded mardown files for links like so:

[file.txt](./file.txt)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 74.0.3729.169
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

  • DO NOT include files inside lib directory.

@aenniw
Copy link
Contributor Author

aenniw commented Jul 6, 2019

Addresses #865

@anikethsaha
Copy link
Member

anikethsaha commented Dec 2, 2019

We need to add tests first in this project then we will check if it's breaking or conflicting any other links

@dellagustin-sap
Copy link

dellagustin-sap commented Jan 22, 2020

Hi all, I am also experiencing this issue.
For taking our own decision on whether to document a workaround in the page our trying to apply a fix (that would introduce for us technical debt), I would like to ask if an estimated timeframe for integrating this PR could be provided.

BR,
Guilherme.

@dellagustin-sap dellagustin-sap mentioned this pull request Feb 4, 2020
Closed
1 task
@anikethsaha
Copy link
Member

anikethsaha commented Feb 5, 2020

@aenniw please rebase and resolve the conflicts.
also change the commit message. make it more detailed in order to fit better for changlog

@anikethsaha anikethsaha self-assigned this Feb 5, 2020
anikethsaha
anikethsaha approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase to run the tests.
else it looks good to me

@anikethsaha anikethsaha removed their assignment Feb 5, 2020
@anikethsaha anikethsaha self-assigned this Feb 14, 2020
@aenniw aenniw force-pushed the bug/865 branch 2 times, most recently from d55c5ba to 14c0688 Compare February 23, 2020 21:53
@aenniw
Migrate relative links to absolute in embedded markdown
40a035e 
Signed-off-by: Martin Mihálek <aenniw@gmail.com>
@aenniw
Copy link
Contributor Author

aenniw commented Feb 23, 2020

Rebased

@anikethsaha anikethsaha reopened this Feb 25, 2020
@anikethsaha anikethsaha merged commit 291c99b into docsifyjs:develop Mar 9, 2020
@Jack-Works
Copy link

Jack-Works commented Mar 28, 2020 •
edited
Loading

Still happened in 4.11.2, example: links in https://jack-works.github.io/bayesian-conspiracy/#/./projects/2019/holoflows-kit.md

@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anikethsaha anikethsaha anikethsaha approved these changes

Assignees

@anikethsaha anikethsaha

Labels

path-resolving

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Embedded files doesn't resolve relative links

5 participants

@aenniw @anikethsaha @dellagustin-sap @Jack-Works @timaschew