This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@arelstone can you please resolve the conflicts and try to simplify the diff if possible. I will review this soon. Its a good enhancement.

@anikethsaha I've resolved the conflicts that is suppose to come after 10 months of idling on any pr.
Took me some time to get into what was up and down. When i submitted this PR god and I knew what was going on.... Today i felt that at somepoint only god knew - Oh well I managed 😄 👏
To get up and running with the code I started writing unit tests for the mess I've created
I see that the e2e test is 🔴. I've tried to run these on my own computer and they are all 💚

I'm not really sure how to simplify the diff any more. I know it seems like a lot of changes, but it really isn't. I basically just copy-pasted each of the methods into a new file.

I've been thinking about doing some kind of attribute parser, but this parser will need to have a lot of special cases for attrs like: size, disabled, no-zoom. These cases is what I could come up with on the top of my mind, there will surely be plenty more. I'm not sure that this will. Such a parser could look something like this:

export const attributeParser = config => {
  return Object.entries(config)
    .map(([attr, value]) => {
      if (attr === 'size') {
        return convertSizeAttr(value)
      }

      return `${attr}="${value}"`
    })
}

const convertSizeAttr = size => {
  const [width, height] = size.split('x')
  if (height && width) {
    return `width="${width}" height="${height}"`
  }

  return `width="${width}" height="${width}"`
}

...of-course this needs to have added a lot more rules for the ones listed above. Again I'm not sure that this is the way to do it. It would just be to move some business logic into a new file..

@arelstone this PR is so good 🎉 . And many thanks for adding unit tests. 💯

About the CI error, it needs some changes with new test cases in e2e. if you want to update them, you can go ahead (refer other test cases) else I will do it after merging this.

tests are failing cause you removed the header link in docs/helper and added few more which is supposed to be like this as per this PR. To fix this, remove this line https://github.com/docsifyjs/docsify/blob/develop/cypress/integration/sidebar/config.spec.js#L242 and remove this file

also, if would be nice if you can do this type of refactoring for other parts of the code as well.
and also if you can help us adding more tests (unit preferable) to this project.