Fix getAndRemoveConfig regex#708
Merged
QingWei-Li merged 3 commits intodocsifyjs:masterfrom Dec 5, 2018
Merged
Conversation
Update getAndRemoveConfig regular expression for prevent cases, when header has name like "foo::bar::baz".
|
It is not clear what you have changed in the PR. AFAIU regexp now works only if there is some whitespace before |
sylwekb
approved these changes
Nov 28, 2018
|
This will also fix my issue :) Waiting for it to get published. Thanks! |
|
@krohrsb You can you my dev build till this time https://uplycdn.com/docs/shEOcKLcylbm/docsify.min.js |
QingWei-Li
pushed a commit
that referenced
this pull request
Feb 19, 2019
* Fix getAndRemoveConfig regex Update getAndRemoveConfig regular expression for prevent cases, when header has name like "foo::bar::baz". * Fix wrong regexp * Fix regex Ignore `:foo` cases
This was referenced Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update getAndRemoveConfig regular expression for prevent cases, when header has name like
# foo::bar::baz.We use docsify for perl, our regular case:
### Some::Module, and without fixed regex we have header like### Some:.Compatible with FireFox.
Please makes sure these boxes are checked before submitting your PR, thank you!
masterbranch.libdirectory.