fix: gracefully handle page loading failures during search indexing#2675
Open
kokovtsev wants to merge 1 commit intodocsifyjs:developfrom
Open
fix: gracefully handle page loading failures during search indexing#2675kokovtsev wants to merge 1 commit intodocsifyjs:developfrom
kokovtsev wants to merge 1 commit intodocsifyjs:developfrom
Conversation
|
@kokovtsev is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gracefully handle page loading failures during the search indexing processing.
Before this fix, the loaded page counter was incremented only in the successful branch of
Docsify.get, so if any request failed then the counter never reached the expected value andsaveDatawas never called.Related issue, if any:
Fixes #2674
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: