update(doc): fix themeColor in configuration.#2160
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sy-records
approved these changes
Aug 3, 2023
trusktr
reviewed
Aug 6, 2023
| --theme-color: deeppink; | ||
| } | ||
| </style> | ||
| ``` |
Member
There was a problem hiding this comment.
Oops, I forgot the code fence. I meant for this to be inside the warning. For example it should be like this:
> **Warning** Deprecated. Use the CSS var `--theme-color` in your `<style>` sheet. Example:
>
> ```html
> <style>
> :root {
> --theme-color: deeppink;
> }
> </style>
> ```and here's what it looks like inside the quote block:
Warning Deprecated. Use the CSS var
--theme-colorin your<style>sheet. Example:<style> :root { --theme-color: deeppink; } </style>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
themeColorconfig doc changed in #2114 .the markdown takes a mistake to treat it as HTML style. See Pink Configuration preview as reproduct.
And, it seems also brings a new feature that we could allow user set
theme-colorper markdown page . 🚀What kind of change does this PR introduce?
Docs
For any code change,
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
Tested in the following browsers: